Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): skip payment method screen if has already started #8353

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

wachunei
Copy link
Member

Description

This PR will only show the Payment Method / Cash out destination screen if it is the first time the user enters the flow, navigating directly to the Build Quote screen.

This is reverting the behavior from this PR #4860

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ONRAMP-1336

Manual testing steps

  1. Open the Buy/Sell flow
  2. If this is the first time, Get Started screen must take the user to the payment method screen
  3. If this is not the first time, user must navigate to Build Quote screen

Screenshots/Recordings

Before

before.mp4

After

after.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jan 19, 2024
@wachunei wachunei requested a review from a team as a code owner January 19, 2024 20:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fa1dd8) 40.34% compared to head (1dcc675) 40.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8353   +/-   ##
=======================================
  Coverage   40.34%   40.34%           
=======================================
  Files        1235     1235           
  Lines       29957    29957           
  Branches     2877     2877           
=======================================
  Hits        12087    12087           
  Misses      17175    17175           
  Partials      695      695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini
tommasini previously approved these changes Jan 23, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wachunei wachunei added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 23, 2024
@bkirb
Copy link
Contributor

bkirb commented Jan 24, 2024

@wachunei LGTM ✅ I tested with first time user and returning user

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jan 24, 2024
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei merged commit c6aec14 into main Jan 24, 2024
26 checks passed
@wachunei wachunei deleted the feat/ramp-skip-pm-screen branch January 24, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run ramp-qa-passed release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants