-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): skip payment method screen if has already started #8353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8353 +/- ##
=======================================
Coverage 40.34% 40.34%
=======================================
Files 1235 1235
Lines 29957 29957
Branches 2877 2877
=======================================
Hits 12087 12087
Misses 17175 17175
Partials 695 695 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6d5f215
to
d18360d
Compare
@wachunei LGTM ✅ I tested with first time user and returning user |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR will only show the Payment Method / Cash out destination screen if it is the first time the user enters the flow, navigating directly to the Build Quote screen.
This is reverting the behavior from this PR #4860
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ONRAMP-1336
Manual testing steps
Screenshots/Recordings
Before
before.mp4
After
after.mp4
Pre-merge author checklist
Pre-merge reviewer checklist