Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Revert "test: bump detox to v20.16 (#8304)" #8371

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Jan 23, 2024

This reverts commit a4e018a.

Description

Android detox appears to be hanging sporadically during execution. If not caught in time, this could result in wasted credits.

Relates to #8361

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

CI Related Section: DO NOT EDIT

Flag used by Bitrise to either run or skip E2E smoke tests

  • Bitrise Flag:[skip ci]

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 23, 2024
@cortisiko cortisiko requested a review from a team as a code owner January 23, 2024 16:52
@cortisiko cortisiko changed the title Detox revert20 16 test: Revert "test: bump detox to v20.16 (#8304)" Jan 23, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

socket-security bot commented Jan 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/detox@20.14.3 environment, eval, filesystem, network, shell, unsafe +316 463 MB wix.mobile

🚮 Removed packages: npm/detox@20.16.0, npm/stream-json@1.8.0

View full report↗︎

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d26e45) 40.33% compared to head (7bd0c44) 40.33%.
Report is 1 commits behind head on main.

❗ Current head 7bd0c44 differs from pull request most recent head e5191a6. Consider uploading reports for the commit e5191a6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8371   +/-   ##
=======================================
  Coverage   40.33%   40.33%           
=======================================
  Files        1235     1235           
  Lines       29949    29949           
  Branches     2875     2875           
=======================================
  Hits        12079    12079           
  Misses      17175    17175           
  Partials      695      695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cortisiko cortisiko merged commit b1b26bc into main Jan 23, 2024
26 checks passed
@cortisiko cortisiko deleted the detox-revert20-16 branch January 23, 2024 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants