Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dedupe deps with Yarn and update CocoaPods lockfile #8401

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Jan 25, 2024

Description

Fix failing CI on main and update outdated CocoaPods lockfile

Related issues

Fixes

  • CI on main failing dedupe step
  • outdated CocoaPods lockfile

Manual testing steps

  • Run yarn deduplicate, no Yarn lockfile changes remaining to commit
  • Run pod:install, no CocoaPods lockfile changes remaining to commit

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Fix failing CI on main
@leotm leotm requested a review from a team as a code owner January 25, 2024 16:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@walletconnect/types@2.9.0, npm/anymatch@3.1.2, npm/safe-json-utils@1.1.1

View full report↗︎

@leotm leotm requested a review from abretonc7s January 25, 2024 16:57
@leotm leotm changed the title Deduplicate deps with Yarn Dedupe deps with Yarn and update CocoaPods lockfile Jan 25, 2024
@leotm leotm added team-mobile-client needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 25, 2024
@leotm leotm changed the title Dedupe deps with Yarn and update CocoaPods lockfile fix: Dedupe deps with Yarn and update CocoaPods lockfile Jan 25, 2024
@leotm leotm added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jan 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2652a24) 40.44% compared to head (cb505a6) 40.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8401   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files        1239     1239           
  Lines       29975    29975           
  Branches     2875     2875           
=======================================
  Hits        12122    12122           
  Misses      17156    17156           
  Partials      697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leotm leotm merged commit f43883f into main Jan 25, 2024
43 of 50 checks passed
@leotm leotm deleted the fix/ci-yarn-deduplicate-deps branch January 25, 2024 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants