Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: you have to press the login button twice (#6633) (#6663) #8404

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: you have to press the login button twice (#6633) (#6663) #8404

merged 1 commit into from
Jan 25, 2024

Conversation

frankvonhoven
Copy link
Contributor

Description

When a user wants to login into the wallet they need to press the login button twice. The issue comes from the way that the Scrollview component is behaving when input is active.

  • Final validation for external PR

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
Fix: #6633
PR: #6663

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tibi77 @leotm
@Cal-L @frankvonhoven @sethkfman
fix: you have to press the login button twice (#6633) (#6663)
aea73a4 
<!--
Thanks for your contribution!

Please ensure that any applicable requirements below are satisfied
before submitting this pull request. This will help ensure a quick and
efficient review cycle.
-->

**Description**

When a user wants to login into the wallet they need to press the login
button twice. The issue comes from the way that the Scrollview component
is behaving when input is active.

**Screenshots/Recordings**

_If applicable, add screenshots and/or recordings to visualize the
before and after of your change_

**Issue**
Fix: #6633 

**Checklist**

* [x] There is a related GitHub issue
* [ ] Tests are included if applicable
* [ ] Any added code is fully documented

---------

Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: Frank von Hoven <141057783+frankvonhoven@users.noreply.github.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
@frankvonhoven frankvonhoven marked this pull request as ready for review January 25, 2024 19:49
@frankvonhoven frankvonhoven requested a review from a team as a code owner January 25, 2024 19:49
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abdea665-403c-47ce-8cd2-7bebf6fbdfdd
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/365df091-fc80-4522-91ef-24ccc3888022
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e45d196) 40.44% compared to head (aea73a4) 40.43%.

Files Patch % Lines
app/components/Views/Login/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8404      +/-   ##
==========================================
- Coverage   40.44%   40.43%   -0.01%     
==========================================
  Files        1239     1239              
  Lines       29975    29976       +1     
  Branches     2875     2875              
==========================================
  Hits        12122    12122              
- Misses      17156    17157       +1     
  Partials      697      697

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvonhoven frankvonhoven merged commit ea21001 into main Jan 25, 2024
32 of 33 checks passed
@frankvonhoven frankvonhoven deleted the temp/validate-ext-pr-login-fix branch January 25, 2024 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
external-contributor release-7.16.0 Issue or pull request that will be included in release 7.16.0 Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You have to press the login button twice.
6 participants
@frankvonhoven @codecov-commenter @Cal-L @sethkfman @metamaskbot @tibi77