fix: you have to press the login button twice (#6633)

[tibi77]

Description

When a user wants to login into the wallet they need to press the login button twice. The issue comes from the way that the Scrollview component is behaving when input is active.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
Fix: #6633

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[tommasini]

Thanks for the contribution @tibi77! LGTM!

[hesterbruikman]

@tibi77 Added a Needs QA label, please stay tuned for QA feedback. I think it'll be good to do a quick check on physical device (Android + iOS)

[leotm]

(see: #6663 (review))

edit: added Fix: prefix in description to auto-close your linked issue @tibi77 thx again

[tommasini]

LGTM with the latest commit

[tibi77]

So I can merge it @leotm ?
My first contribution to this repo, not sure how it goes :D

[tibi77]

@leotm could you approve the workflow so we can merge this

[cortisiko]

@tibi77 can you test this PR and provide recording details of what was tested?

[hesterbruikman]

@tibi77 bumping @cortisiko's comment, would love to see this included, but we'd need a recording of testing before this can be merged

[tibi77]

@hesterbruikman just saw this
recording now

[tibi77]

Screen.Recording.2023-10-09.at.21.10.45.mov

The issue was that the button for login/unlock had to be pressed twice, now, with this change you need to press the button only once
The reason that this bug happened was that the keyboard aware scroll swallows the click event and the button does not get that event, so, to fix it, we remove the event handling from the keyboard and we closed the Keyboard manually.

You can't really see it on the video but i m pressing twice the button, the keyboard goes down and only than i can press on the button

[tibi77]

@tommasini @leotm solved the conflicts, and requested the review again

[tommasini]

LGTM!

[hesterbruikman]

You're ready to merge @tibi77 ! Thanks so much for your contribution and patience! Looking forward to see this improvement in the app

cc @chrisleewilcox

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e45d196) 40.44% compared to head (f1da997) 40.43%.

Files	Patch %	Lines
app/components/Views/Login/index.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6663      +/-   ##
==========================================
- Coverage   40.44%   40.43%   -0.01%     
==========================================
  Files        1239     1239              
  Lines       29975    29976       +1     
  Branches     2875     2875              
==========================================
  Hits        12122    12122              
- Misses      17156    17157       +1     
  Partials      697      697              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leotm]

@sethkfman can you see why GH's still expecting/waiting on the status of the final SonarCloud check?
even tho summary shows a pass and the job's marked complete after we skip it (same after re-runs)

remembering from recent sonar PRs we skipped it for ext contributors in #7086
but still got couple more ext contributor PRs hanging about on this step

tried manually merging via command line but ofc our branch protection doesn't allow

[tibi77]

@leotm I still see sonar not passing... what would be the next steps to solve this?

[hesterbruikman]

cc @frankvonhoven

[tibi77]

it seems that we have just Bitrise failing, but it looks like it fails from the get go

[sethkfman]

This PR looks good we are merging into a temp branch were E2E testing can be run for final validation.