Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: Fix/8352 source map stack trace (#8467)" #8508

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 1, 2024

This reverts commit 583ce06.

This change breaks e2e smoke on Bitrise. Will fix before merging again

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Feb 1, 2024
@Cal-L Cal-L requested a review from a team as a code owner February 1, 2024 20:16
Copy link
Contributor

github-actions bot commented Feb 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sentry/react-native@5.8.1 network Transitive: environment, eval, filesystem, shell, unsafe +403 159 MB sentry-bot
npm/stack-beautifier@1.0.2 Transitive: filesystem, shell +3 815 kB kmag

🚮 Removed packages: npm/@sentry/react-native@5.11.1

View full report↗︎

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff8e9b0) 40.67% compared to head (7a12210) 40.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8508   +/-   ##
=======================================
  Coverage   40.67%   40.67%           
=======================================
  Files        1240     1240           
  Lines       30011    30011           
  Branches     2870     2870           
=======================================
  Hits        12206    12206           
  Misses      17107    17107           
  Partials      698      698           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L Cal-L merged commit 5c2082d into main Feb 1, 2024
35 checks passed
@Cal-L Cal-L deleted the revert/8352-sentry-source-maps branch February 1, 2024 23:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants