Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable blockaid by default #8524

Merged
merged 3 commits into from
Feb 8, 2024
Merged

feat: enable blockaid by default #8524

merged 3 commits into from
Feb 8, 2024

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Feb 5, 2024

Description

Enable blockaid validations for all users by default

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1984

Manual testing steps

  1. Install MM
  2. See that blockaid is enabled by default

Screenshots/Recordings

Before

After

http://recordit.co/DhSljPOe5n

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title Enable blockaid by default on mobile feat: enable blockaid by default Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0b5d647) 40.66% compared to head (9c212df) 40.90%.
Report is 17 commits behind head on main.

Files Patch % Lines
app/components/Views/BrowserTab/index.js 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8524      +/-   ##
==========================================
+ Coverage   40.66%   40.90%   +0.23%     
==========================================
  Files        1240     1245       +5     
  Lines       30013    30148     +135     
  Branches     2870     2894      +24     
==========================================
+ Hits        12206    12333     +127     
- Misses      17109    17112       +3     
- Partials      698      703       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa marked this pull request as ready for review February 7, 2024 15:59
@blackdevelopa blackdevelopa requested a review from a team as a code owner February 7, 2024 15:59
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Feb 7, 2024
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8df85bb-4b3e-478b-91d9-8004f4fd36ca
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@blackdevelopa blackdevelopa added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4f990a3-8fd1-43e7-8a4a-d67216ee68c8
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa self-assigned this Feb 8, 2024
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 8, 2024
@blackdevelopa blackdevelopa merged commit 86d3940 into main Feb 8, 2024
35 checks passed
@blackdevelopa blackdevelopa deleted the 1984/blockaid-default branch February 8, 2024 16:44
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants