Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable blockaid What's New Copy #8554

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Feb 8, 2024

Description

Updates the copy for blockaid turned on by default

Related issues

Fixes:

Manual testing steps

  1. Install MM
  2. See the What's new copy for blockaid

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title Enable blockaid What's New Copy fix: Enable blockaid What's New Copy Feb 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34f9da1) 0.00% compared to head (d1d8c78) 40.90%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #8554       +/-   ##
=========================================
+ Coverage      0   40.90%   +40.90%     
=========================================
  Files         0     1245     +1245     
  Lines         0    30148    +30148     
  Branches      0     2894     +2894     
=========================================
+ Hits          0    12333    +12333     
- Misses        0    17112    +17112     
- Partials      0      703      +703     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Feb 8, 2024
@blackdevelopa blackdevelopa self-assigned this Feb 8, 2024
@blackdevelopa blackdevelopa marked this pull request as ready for review February 8, 2024 13:49
@blackdevelopa blackdevelopa requested a review from a team as a code owner February 8, 2024 13:49
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab6c53b2-c55d-49ad-940d-1c4af984ab54
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@blackdevelopa blackdevelopa merged commit 124caa5 into main Feb 13, 2024
34 of 36 checks passed
@blackdevelopa blackdevelopa deleted the enable_blockaid_copy branch February 13, 2024 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants