-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename DAPP_VISITED to DAPP_VIEWED #8838
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 3d18ff4 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8838 +/- ##
==========================================
- Coverage 41.61% 41.60% -0.02%
==========================================
Files 1269 1268 -1
Lines 30869 30862 -7
Branches 3086 3086
==========================================
- Hits 12847 12840 -7
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Quality Gate passedIssues Measures |
Description
These changes renames
Dapp Visited
->Dapp Viewed
to match event name with extensionOriginal mobile PR here - #8520
Original mobile ticket - https://github.com/MetaMask/mobile-planning/issues/1300
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
dapp-viewed.mov
Pre-merge author checklist
Pre-merge reviewer checklist