Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename DAPP_VISITED to DAPP_VIEWED #8838

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 4, 2024

Description

These changes renames Dapp Visited -> Dapp Viewed to match event name with extension

Original mobile PR here - #8520

Original mobile ticket - https://github.com/MetaMask/mobile-planning/issues/1300

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

dapp-viewed.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner March 4, 2024 21:57
Copy link
Contributor

github-actions bot commented Mar 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-mobile-platform No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3d18ff4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c776b060-3ec0-4c39-b58e-395c36aa3ecc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 41.60%. Comparing base (27c9362) to head (3d18ff4).

Files Patch % Lines
app/components/Views/BrowserTab/index.js 0.00% 4 Missing ⚠️
...components/Views/AccountConnect/AccountConnect.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8838      +/-   ##
==========================================
- Coverage   41.61%   41.60%   -0.02%     
==========================================
  Files        1269     1268       -1     
  Lines       30869    30862       -7     
  Branches     3086     3086              
==========================================
- Hits        12847    12840       -7     
  Misses      17245    17245              
  Partials      777      777              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarcloud bot commented Mar 6, 2024

@Cal-L Cal-L merged commit f743ea0 into main Mar 6, 2024
29 checks passed
@Cal-L Cal-L deleted the fix/rename-dapp-visited-to-viewed branch March 6, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants