Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix network verification chainID and name verification for popular network #8953

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix: fix network verification chainID and name verification for popular network #8953

merged 3 commits into from
Mar 18, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Mar 15, 2024

Description

the chainId must be displayed in decimal instead of hexadecimal in the network verification modal.
the name warning must not be displayed in the case of a popular network.

Related issues

Fixes: #8950 , #8951

Manual testing steps

  1. Go to settings then network
  2. click on optimism network add button
  3. a network verification modal will be displayed , check the value of the chainID
  4. a warning name will be displayed

Screenshots/Recordings

Before

Bug

After

Screenshot 2024-03-15 at 12 12 44

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner March 15, 2024 11:13
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the type-bug Something isn't working label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.67%. Comparing base (61536d6) to head (02bfa50).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8953   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files        1271     1271           
  Lines       30921    30921           
  Branches     3092     3092           
=======================================
  Hits        13506    13506           
  Misses      16636    16636           
  Partials      779      779

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb force-pushed the fix-network-verification branch 2 times, most recently from 3542db0 to 90da418 Compare March 15, 2024 11:57
@MetaMask MetaMask deleted a comment from socket-security bot Mar 15, 2024
@MetaMask MetaMask deleted a comment from socket-security bot Mar 15, 2024
@salimtb salimtb linked an issue Mar 15, 2024 that may be closed by this pull request
[Bug]: Netwrok name warning showed up in case of popular network #8951
Closed
@salimtb salimtb force-pushed the fix-network-verification branch 3 times, most recently from 0a54e66 to c8c98ce Compare March 15, 2024 17:04
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024
@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b534824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6804f85-3ecd-4494-80df-7435da039977

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024
@salimtb salimtb requested a review from a team as a code owner March 18, 2024 18:58
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 143e0c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/08e5b02b-b294-4c96-bb6b-bbdce8583329

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Cal-L Cal-L merged commit 521ef63 into main Mar 18, 2024
30 checks passed
@Cal-L Cal-L deleted the fix-network-verification branch March 18, 2024 20:05
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets type-bug Something isn't working
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Netwrok name warning showed up in case of popular network [Bug]: chainID is displayed in hex
5 participants
@salimtb @codecov-commenter @Cal-L @gauthierpetetin @metamaskbot