[Bug]: Netwrok name warning showed up in case of popular network #8951
Assignees
Labels
regression-prod-7.18.0
Regression bug that was found in production in release 7.18.0
release-7.19.0
Issue or pull request that will be included in release 7.19.0
type-bug
Something isn't working
Comments
metamaskbot
added
the
regression-prod-7.18.0
13 tasks
13 tasks
Cal-L
added a commit
that referenced
this issue
Mar 18, 2024
…ar network (#8953) ## **Description** the chainId must be displayed in decimal instead of hexadecimal in the network verification modal. the name warning must not be displayed in the case of a popular network. ## **Related issues** Fixes: #8950 , #8951 ## **Manual testing steps** 1. Go to settings then network 2. click on optimism network add button 3. a network verification modal will be displayed , check the value of the chainID 4. a warning name will be displayed ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Cal Leung <cleun007@gmail.com>
metamaskbot
added
the
release-7.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
when we try to add the optimism popular network , a name warning is displayed
Expected behavior
the warning should not be displayed
Screenshots/Recordings
No response
Steps to reproduce
Error messages or log output
No response
Version
7.18.0
Build type
None
Device
iphone 13
Operating system
iOS
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: