Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "chore: Include env variable copying into yarn setup command" #8976

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: Revert "chore: Include env variable copying into yarn setup command" #8976

merged 1 commit into from
Mar 18, 2024
+7 −14

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 18, 2024

Reverts #8919

Revert this PR for now since it breaks E2E smoke

@Cal-L Cal-L requested a review from a team as a code owner March 18, 2024 17:46
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the title Revert "chore: Include env variable copying into yarn setup command" fix: Revert "chore: Include env variable copying into yarn setup command" Mar 18, 2024
@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 797b9f2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4dd80a91-6bfc-443e-afd7-a1ae8d945714

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@kylanhurt kylanhurt self-requested a review March 18, 2024 17:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 18, 2024
tommasini
tommasini approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 59b43b4 into main Mar 18, 2024
43 of 49 checks passed
@Cal-L Cal-L deleted the revert-8919-kylan/readme-improvements branch March 18, 2024 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylanhurt kylanhurt kylanhurt approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cal-L @kylanhurt @tommasini @metamaskbot