Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update controller utils to 5.0.2 #9079

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

tommasini
Copy link
Contributor

Description

Updated the patch accordingly, and introduced networkIds list hardcoded for we keep the ens legacy functions working

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

ENS solving:

Screen.Recording.2024-03-27.at.17.50.01.mov

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…duced networkIds list hardcoded for we keep the ens legacy functions working
@tommasini tommasini requested review from a team as code owners March 27, 2024 18:04
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 27, 2024
@tommasini
Copy link
Contributor Author

The ts lint issue on this PR will be solved when the network controller update to v13 be merged because that network controller version will update the dependency of controller utils to v^5.0.0

@bergeron bergeron self-requested a review March 27, 2024 19:02
app/util/ENSUtils.js Outdated Show resolved Hide resolved
app/util/ENSUtils.js Outdated Show resolved Hide resolved
bergeron
bergeron previously approved these changes Mar 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (18e2f11) to head (ba3af01).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9079      +/-   ##
==========================================
+ Coverage   45.54%   45.55%   +0.01%     
==========================================
  Files        1272     1272              
  Lines       31236    31236              
  Branches     3188     3188              
==========================================
+ Hits        14225    14231       +6     
+ Misses      16171    16167       -4     
+ Partials      840      838       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix lint issue

@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ba3af01
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7602daa1-17c2-46dc-a4b6-973b0dcb1529

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c09c6d6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/709845e1-828e-40e0-abe6-f74f087a64ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 28, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - E2E failure due to flakiness and is most likely not related to this PR

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini merged commit 6e87690 into main Mar 29, 2024
34 of 35 checks passed
@tommasini tommasini deleted the feat/1622-controller-utils-v5-0-2 branch March 29, 2024 02:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 29, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 29, 2024
@tommasini tommasini restored the feat/1622-controller-utils-v5-0-2 branch April 5, 2024 09:03
@tommasini
Copy link
Contributor Author

This PR was reverted and it was created this one to re introduce this changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants