-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update controller utils to 5.0.2 #9079
Conversation
…duced networkIds list hardcoded for we keep the ens legacy functions working
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
The ts lint issue on this PR will be solved when the network controller update to v13 be merged because that network controller version will update the dependency of controller utils to v^5.0.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9079 +/- ##
==========================================
+ Coverage 45.54% 45.55% +0.01%
==========================================
Files 1272 1272
Lines 31236 31236
Branches 3188 3188
==========================================
+ Hits 14225 14231 +6
+ Misses 16171 16167 -4
+ Partials 840 838 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix lint issue
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - E2E failure due to flakiness and is most likely not related to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR was reverted and it was created this one to re introduce this changes |
Description
Updated the patch accordingly, and introduced networkIds list hardcoded for we keep the ens legacy functions working
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
ENS solving:
Screen.Recording.2024-03-27.at.17.50.01.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist