feat: Update controller utils to 5.0.2 #9149
Merged
+55
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duced networkIds list hardcoded for we keep the ens legacy functions working
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
…or controller utils package
7 tasks
tommasini
added
needs-dev-review
|
tommasini
added
Run Smoke E2E
|
tommasini
added a commit
that referenced
this pull request
Apr 12, 2024
## **Description** This PR addresses the update to the Asset Controller v14 Created Core branch to address patch changes: patch/mobile-assets-controllers-v-14-0-0 Fixed issue of token being automatically imported when requested by a dapp. Changed breaking changes on addToken and watchAsset function signature. Important to note that this version of assets controller is pointing to version 5 of controller utils, therefore the auto detect tokens will only be available when this [PR](#9149) is merged ## **Related issues** Fixes: MetaMask/mobile-planning#1620 ## **Manual testing steps** 1. imported tokens on mainnet 2. Imported tokens on custom network 3. Auto-detect tokens on mainnet & custom network 4. Import token via dapp 5. ## **Screenshots/Recordings** Auto detect tokens, import token via dapp: https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9 Add custom token/ hide token: https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
tommasini
added a commit
that referenced
this pull request
Apr 12, 2024
## **Description** This PR addresses the update to the Asset Controller v14 Created Core branch to address patch changes: patch/mobile-assets-controllers-v-14-0-0 Fixed issue of token being automatically imported when requested by a dapp. Changed breaking changes on addToken and watchAsset function signature. Important to note that this version of assets controller is pointing to version 5 of controller utils, therefore the auto detect tokens will only be available when this [PR](#9149) is merged ## **Related issues** Fixes: MetaMask/mobile-planning#1620 ## **Manual testing steps** 1. imported tokens on mainnet 2. Imported tokens on custom network 3. Auto-detect tokens on mainnet & custom network 4. Import token via dapp 5. ## **Screenshots/Recordings** Auto detect tokens, import token via dapp: https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9 Add custom token/ hide token: https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
MarioAslau
approved these changes
Apr 12, 2024
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.22.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the patch accordingly, and introduced networkIds list hardcoded for we keep the ens legacy functions working
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1622
Manual testing steps
Screenshots/Recordings
ENS solving:
Screen.Recording.2024-04-11.at.11.15.53.mov
Sepolia linea network:
Uploading Screen Recording 2024-04-11 at 11.16.38.mov…
NFT auto detection working
Screen.Recording.2024-04-12.at.14.23.43.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist