Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for missing identities on migration 36 #9082

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 27, 2024

Description

This PR adds a check for ensuring that identities are defined under PreferencesController for migration 36.
More context here - #9080

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner March 27, 2024 22:08
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-extension-platform No E2E Smoke Needed If the PR does not need E2E smoke test run labels Mar 27, 2024
@Cal-L Cal-L changed the title fix: Check for missing identities fix: Check for missing identities on migration 36 Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (3c0ac7d) to head (8ad5f12).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9082      +/-   ##
==========================================
- Coverage   45.55%   45.55%   -0.01%     
==========================================
  Files        1272     1272              
  Lines       31235    31238       +3     
  Branches     3188     3189       +1     
==========================================
+ Hits        14230    14231       +1     
- Misses      16167    16168       +1     
- Partials      838      839       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L Cal-L merged commit 7aaaf01 into main Mar 27, 2024
42 checks passed
@Cal-L Cal-L deleted the fix/refine-migration-36 branch March 27, 2024 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-extension-platform team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants