-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert Update controller utils to 5.0.2 #9123
Conversation
This reverts commit 6e87690.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9123 +/- ##
==========================================
- Coverage 46.05% 46.05% -0.01%
==========================================
Files 1273 1273
Lines 31274 31273 -1
Branches 3195 3195
==========================================
- Hits 14404 14403 -1
Misses 16027 16027
Partials 843 843 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 5cd79ba Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
This reverts commit 6e87690.
Description
Revert Update controller utils to 5.0.2
The controller util dependency of network controller v12 is on v4 and it's not getting the patch with linea sepolia code applied, which makes updating the controller utils dependent of network controller v13 update, for simplicity we will revert this PR and then merge it after network controller v13 PR is merged
Related issues
Fixes: #9111
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-04-03.at.19.11.21.mov
Sendflow & dapp transaction
Screen.Recording.2024-04-04.at.09.54.11.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist