Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert Update controller utils to 5.0.2 #9123

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 3, 2024

This reverts commit 6e87690.

Description

Revert Update controller utils to 5.0.2

The controller util dependency of network controller v12 is on v4 and it's not getting the patch with linea sepolia code applied, which makes updating the controller utils dependent of network controller v13 update, for simplicity we will revert this PR and then merge it after network controller v13 PR is merged

Related issues

Fixes: #9111

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screen.Recording.2024-04-03.at.19.11.21.mov

Sendflow & dapp transaction

Screen.Recording.2024-04-04.at.09.54.11.mov

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested review from a team as code owners April 3, 2024 18:20
Copy link
Contributor

github-actions bot commented Apr 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Apr 3, 2024
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.05%. Comparing base (51a14e0) to head (5cd79ba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9123      +/-   ##
==========================================
- Coverage   46.05%   46.05%   -0.01%     
==========================================
  Files        1273     1273              
  Lines       31274    31273       -1     
  Branches     3195     3195              
==========================================
- Hits        14404    14403       -1     
  Misses      16027    16027              
  Partials      843      843              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5cd79ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbe5c805-67a2-4d4a-acc9-50155e453045

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@tommasini tommasini merged commit 123d452 into main Apr 4, 2024
42 checks passed
@tommasini tommasini deleted the fix/9111-revert-controller-utils branch April 4, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 4, 2024
@tommasini tommasini added release-7.20.0 Issue or pull request that will be included in release 7.20.0 and removed release-7.21.0 Issue or pull request that will be included in release 7.21.0 labels Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Not able to switch to Linea Sepolia Test Network
6 participants