Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update popular network #9161

Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat: update popular network #9161

merged 2 commits into from
Apr 10, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 8, 2024

Description

We are updating the popular networks list each quarter based on usage found on the array below:
Screenshot 2024-04-10 at 17 25 52

Todo now ( on this PR )

  • network fantom and harmony removed, network base and zk-synv era mainnet added.
  • Avalanche should use infura RPC
  • Palm network should be removed

for scroll , zetachain and opBNB mainnet , we work with infura and need to source them with DIN , once this is done we'll integrate them as a popular network in a second PR
Berachain Artio is a testnet ( you can skip it )

Related issues

Fixes: #9160

Manual testing steps

  1. Go to the add network modal and click on add network
  2. check the list of popular network

Screenshots/Recordings

Before

popular-before

After

Screenshot 2024-04-10 at 17 15 28

Screenshot 2024-04-10 at 17 16 16

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 8, 2024
@salimtb salimtb requested a review from a team as a code owner April 8, 2024 08:44
Copy link
Contributor

github-actions bot commented Apr 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing
darkwing previously approved these changes Apr 9, 2024
darkwing
darkwing previously approved these changes Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
58.8% Duplication on New Code

See analysis details on SonarCloud

@salimtb salimtb requested a review from darkwing April 10, 2024 15:12
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@salimtb salimtb merged commit 93d6a6f into main Apr 10, 2024
49 checks passed
@salimtb salimtb deleted the update-popular-network branch April 10, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update popular network list
4 participants