chore(deps): remove useless @ethereumjs/common direct dependency #9171

dependabot · 2024-04-09T08:39:59Z

Remove useless @ethereumjs/common direct dependency

Important

After bumping version, it appeared that ethereumjs/common was not required anymore in the app as a direct dep.
This allowed removing @ethereumjs/common and bump other indirect dependencies that were locked by this direct ethereumjs/common dependency version.
ethereumjs/common is still used but in other modules with other versions.

This PR:

removes @ethereumjs/common dependency (usage and package import)
updates indirect dependencies not locked anymore
fixes export and imports of buildUnserializedTransaction function
dedup updated yarn lock

Initial dependabot description

Bumps @ethereumjs/common from 2.6.5 to 4.3.0.

Release notes

Sourced from @ethereumjs/common's releases.

@ethereumjs/common v4.3.0

Full 4844 Browser Readiness

WASM KZG

Shortly following the "Dencun Hardfork Support" release round from last month, this is now the first round of releases where the EthereumJS libraries are now fully browser compatible regarding the new 4844 functionality, see PRs #3294 and #3296! 🎉

Our WASM wizard @acolytec3 has spent the last two weeks and created a WASM build of the c-kzg library which we have released under the kzg-wasm name on npm (and you can also use independently for other projects). See the newly created GitHub repository for some library-specific documentation.

This WASM KZG library can now be used for KZG initialization (replacing the old recommended c-kzg initialization), see the respective README section from the tx library for usage instructions (which is also accurate for the other using upstream libraries like block or EVM).

Note that kzg-wasm needs to be added manually to your own dependencies and the KZG initialization code needs to be adopted like the following (which you will likely want to do in most cases, so if you deal with post Dencun EVM bytecode and/or 4844 blob txs in any way):
import { loadKZG } from 'kzg-wasm'
import { Chain, Common, Hardfork } from '@ethereumjs/common'
const kzg = await loadKZG()
// Instantiate common
const common = new Common({
chain: Chain.Mainnet,
hardfork: Hardfork.Cancun,
customCrypto: { kzg },
})
Manual addition is necessary because we did not want to bundle our libraries with WASM code by default, since some projects are then prevented from using our libraries.

Note that passing in the KZG setup file is not necessary anymore, since this is now defaulting to the setup file from the official KZG ceremony (which is now bundled with the KZG library).

Trie Node.js Import Bug

Since this fits well also to be placed here relatively prominently for awareness: we had a relatively nasty bug in the @ethereumjs/trie library with a Node.js web stream import also affecting browser compatibility, see PR #3280. This bug has been fixed along with these releases and this library now references the updated trie library version.

Other Changes

TypeScript type fixes leading to build problems with certain tools (Vercel), PR #3306

Early support for EIP-2935 - "Save historical block hashes in state" (Verkle related, likely subject to change), PRs #3268 and #3327

@ethereumjs/common v4.2.0

Dencun Hardfork Support

While all EIPs contained in the upcoming Dencun hardfork run pretty much stable within the EthereumJS libraries for quite some time, this is the first release round which puts all this in the official space and removes "experimental" labeling preparing for an imminent Dencun launch on the last testnets (Holesky) and mainnet activation! 🎉

Dencun hardfork on the execution side is called Cancun and can be activated within the EthereumJS libraries (default hardfork still Shanghai) with a following common instance:
</tr></table> 

... (truncated)

Commits

48e6a30 4844 Browser Readiness Releases (#3297)
a413006 Update EIP-2935 to latest draft spec (#3327)
e38a521 Fix RPCStateManager Inconsistincy (#3323)
a70312d Integrate Simplified kzg-wasm Version / Deprecate Util.initKZG() (#3321)
906b362 export getOpcodesForHF (#3322)
6766a5d EVM/VM create() Static Constructor Reworking (#3315)
20d088e Fix node versions (#3286)
891ee51 Trie: add partialPath parameter to trie.findPath() (#3305)
435606e Common Type Fixes (#3307)
5e3cfdd Update rustbn-wasm usage (#3304)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

socket-security · 2024-04-09T08:42:58Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@scure/base@1.1.6	None	`0`	80.4 kB	paulmillr

🚮 Removed packages: npm/@noble/curves@1.1.0, npm/@scure/base@1.1.3

View full report↗︎

socket-security · 2024-04-09T08:43:01Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

NicolasMassart · 2024-04-10T17:48:17Z

@dependabot rebase

Bumps [@ethereumjs/common](https://github.com/ethereumjs/ethereumjs-monorepo) from 2.6.5 to 4.3.0. - [Release notes](https://github.com/ethereumjs/ethereumjs-monorepo/releases) - [Commits](https://github.com/ethereumjs/ethereumjs-monorepo/compare/@ethereumjs/common@2.6.5...@ethereumjs/common@4.3.0) --- updated-dependencies: - dependency-name: "@ethereumjs/common" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

remove common as new TransactionFactory doesn't need it fix the file export and tsdoc

github-actions · 2024-04-10T22:00:36Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-04-10T22:06:17Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 26f057b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62ff687b-61de-439e-b70b-2207ccdacb6b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart · 2024-04-10T22:11:10Z

@SocketSecurity ignore npm/@ethereumjs/util@9.0.3

github-actions · 2024-04-10T22:36:21Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7384b58
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfce01d9-1dcb-4478-b62b-31d9048d8fef

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart · 2024-04-10T23:00:39Z

After bumping version, it appeared that ethereumjs/common was not required anymore in the app as a direct dep.
It allowed removing it and bump other indirect dependencies that were locked by this direct ethereumjs/common dependency version.
ethereumjs/common is still used but in other modules with other versions.
Adding this in PR description.

sonarcloud · 2024-04-16T12:59:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dependabot bot requested a review from a team as a code owner April 9, 2024 08:40

dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code team-mobile-platform labels Apr 9, 2024

dependabot bot force-pushed the dependabot/npm_and_yarn/ethereumjs/common-4.3.0 branch from 5cb4b02 to 017bb11 Compare April 10, 2024 17:50

fix tx used to estimate fees

26f057b

remove common as new TransactionFactory doesn't need it fix the file export and tsdoc

NicolasMassart self-assigned this Apr 10, 2024

NicolasMassart added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 10, 2024

NicolasMassart and others added 3 commits April 11, 2024 00:12

dedup

01bb01c

Merge branch 'main' into dependabot/npm_and_yarn/ethereumjs/common-4.3.0

097b79b

remove now useless @ethereumjs/common

7384b58

NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 10, 2024

NicolasMassart changed the title ~~chore(deps): bump @ethereumjs/common from 2.6.5 to 4.3.0~~ chore(deps): remove useless @ethereumjs/common Apr 10, 2024

NicolasMassart changed the title ~~chore(deps): remove useless @ethereumjs/common~~ chore(deps): remove useless @ethereumjs/common direct dependency Apr 10, 2024

NicolasMassart added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024

legobeat approved these changes Apr 16, 2024

View reviewed changes

Merge branch 'main' into dependabot/npm_and_yarn/ethereumjs/common-4.3.0

51c1dfe

NicolasMassart approved these changes Apr 16, 2024

View reviewed changes

NicolasMassart merged commit 0e1d3d1 into main Apr 16, 2024
31 checks passed

NicolasMassart deleted the dependabot/npm_and_yarn/ethereumjs/common-4.3.0 branch April 16, 2024 13:42

github-actions bot locked and limited conversation to collaborators Apr 16, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 16, 2024

metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): remove useless @ethereumjs/common direct dependency #9171

chore(deps): remove useless @ethereumjs/common direct dependency #9171

dependabot bot commented on behalf of github Apr 9, 2024 •

edited by NicolasMassart

socket-security bot commented Apr 9, 2024 •

edited

socket-security bot commented Apr 9, 2024 •

edited

NicolasMassart commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 •

edited by metamaskbot

NicolasMassart commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 •

edited by metamaskbot

NicolasMassart commented Apr 10, 2024

sonarcloud bot commented Apr 16, 2024

chore(deps): remove useless @ethereumjs/common direct dependency #9171

chore(deps): remove useless @ethereumjs/common direct dependency #9171

Conversation

dependabot bot commented on behalf of github Apr 9, 2024 • edited by NicolasMassart

Initial dependabot description

@​ethereumjs/common v4.3.0

Full 4844 Browser Readiness

WASM KZG

Trie Node.js Import Bug

Other Changes

@​ethereumjs/common v4.2.0

Dencun Hardfork Support

socket-security bot commented Apr 9, 2024 • edited

socket-security bot commented Apr 9, 2024 • edited

NicolasMassart commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 • edited by metamaskbot

Bitrise

NicolasMassart commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 • edited by metamaskbot

Bitrise

NicolasMassart commented Apr 10, 2024

sonarcloud bot commented Apr 16, 2024

Quality Gate passed

dependabot bot commented on behalf of github Apr 9, 2024 •

edited by NicolasMassart

`@ethereumjs/common` v4.3.0

`@ethereumjs/common` v4.2.0

socket-security bot commented Apr 9, 2024 •

edited

socket-security bot commented Apr 9, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited by metamaskbot

github-actions bot commented Apr 10, 2024 •

edited by metamaskbot