fix: add symbol check on network add custom form

[salimtb]

Description

Problem: When adding tokens, just like on Extension, we should add in a warning for users when the symbol doesn’t match the detected symbol.

following an initial investigation, here's what we found lacking in the mobile version:

1. Mobile version only conducts network verification during network editing.
2. The way the mobile version suggests the network symbol differs from the extension.
3. The warning symbol on mobile varies from the extension in both appearance and content.

Related issues

Fixes: #9237

Manual testing steps

1. Go to add custom network form
2. Add any network
3. if symbol is incorrect , warning ,message should be displayed

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[NicholasEllul]

@salimtb please ignore the scan failure for now. Our team is investigating the issue 👍

[salimtb]

@salimtb please ignore the scan failure for now. Our team is investigating the issue 👍

thnx for letting me know @NicholasEllul

[darkwing]

A few nits

resolved

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1bfeed8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f10c5ca6-c169-402e-a4f9-f7ea41e4bf72

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

Left some comments

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3264b03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d15d8cf-19a8-4daf-bcae-b042e7751846

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 45.81%. Comparing base (f7466da) to head (3264b03).
Report is 44 commits behind head on main.

Files	Patch %	Lines
...Settings/NetworksSettings/NetworkSettings/index.js	0.00%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9177      +/-   ##
==========================================
+ Coverage   45.58%   45.81%   +0.23%     
==========================================
  Files        1289     1298       +9     
  Lines       31973    32028      +55     
  Branches     3314     3328      +14     
==========================================
+ Hits        14574    14674     +100     
+ Misses      16528    16472      -56     
- Partials      871      882      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b84d61c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd9ddb4d-2212-47b5-afc1-53a9630aca78

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6ebe1c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3d32b4d-1b29-4603-9703-d24bf7ff1b60

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[tommasini]

@salimtb , I was trying to see if it would be possible to confirm to add network after fill the symbol property (Because by the recordings it seems that the warning only displays after the text input being unfocused) and I notice that the confirm button doesn't appear to me at all on the simulator, am I doing something wrong?
https://github.com/MetaMask/metamask-mobile/assets/46944231/3d314bd9-37d1-4a5b-afd2-636c47159ee8

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
35.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a476d44
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4c606429-314d-43c8-8cda-990f9a166724

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[salimtb]

@salimtb , I was trying to see if it would be possible to confirm to add network after fill the symbol property (Because by the recordings it seems that the warning only displays after the text input being unfocused) and I notice that the confirm button doesn't appear to me at all on the simulator, am I doing something wrong? https://github.com/MetaMask/metamask-mobile/assets/46944231/3d314bd9-37d1-4a5b-afd2-636c47159ee8

hey @tommasini ,
can you check again now if you have the same behavior ? i think something wrong happened after a rebase