feat: Update assets controllers v14 #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o delete networkId property from the network controller state and added a network id property to our own internal property, created the reducer and the action for that property and added the dispatch to the engine event subscriber, update the patch of network controller, updated test cases and initial states with new data structure with the networkId property
…only look for network id when the network did change
…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function
…etworkProvider that will contain our internal property regarding a network provider, updated on the migrations files, backgroundBridge and related components, the test files were updated accordingly as well. On Engine file was added a subscribe of the networkWillChange event to make sure we have the networkId property reseted if the intention of switching starts
… want to investigate any issue, this is the better approach to not polute Sentry and save it for the investigations
… to fetch network id
…ageProvider with the property networkId, updated files with the new property inpageProvider, deleting old actions and reducers files about networkProvider, addressed review on unit tests, changed initial root state and fixture builder initial state with the inpageProvider, and updated respective migrations 033 and 037 with reviews and new property, updated also engine file imports with the action of the slice of inpageprovider
… fresh install the networkId would not be updated because the event network did change did not trigger
tommasini
added
Run Smoke E2E
|
wachunei
previously approved these changes
Apr 11, 2024
tommasini
added
Run Smoke E2E
|
tommasini
added
Run Smoke E2E
NicolasMassart
approved these changes
Apr 12, 2024
tommasini
added
Run Smoke E2E
|
tommasini
added
Run Smoke E2E
|
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.22.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the update to the Asset Controller v14
Created Core branch to address patch changes: patch/mobile-assets-controllers-v-14-0-0
Fixed issue of token being automatically imported when requested by a dapp.
Changed breaking changes on addToken and watchAsset function signature.
Important to note that this version of assets controller is pointing to version 5 of controller utils, therefore the auto detect tokens will only be available when this PR is merged
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1620
Manual testing steps
Screenshots/Recordings
Auto detect tokens, import token via dapp:
Screen.Recording.2024-04-11.at.10.13.51.mov
Add custom token/ hide token:
Screen.Recording.2024-04-11.at.10.14.44.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist