Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ramp): default networks state to array #9193

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Apr 10, 2024

Description

This PR fixes incident 642 https://consensys.slack.com/archives/C06TJ8T4K1T

This PR cherry picks this commit 7f7636e (result from merging this PR #9008)

And adds a defaulting mechanism to an empty array for possibly corrupted existing states of the user.

Related issues

Fixes: incident 642 https://consensys.slack.com/archives/C06TJ8T4K1T

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei force-pushed the hotfix/ramp-networks-array-state branch from 6ab565f to 69b8661 Compare April 10, 2024 14:58
@wachunei wachunei changed the base branch from release/7.19.0 to release/7.19.1 April 10, 2024 15:10
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 10, 2024
@wachunei wachunei marked this pull request as ready for review April 10, 2024 15:11
@wachunei wachunei requested review from a team as code owners April 10, 2024 15:11
Copy link
Contributor

github-actions bot commented Apr 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 48b24df
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2eab659e-c7b2-4966-9217-603cc00f603c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

@sethkfman sethkfman merged commit 14c4803 into release/7.19.1 Apr 10, 2024
29 of 34 checks passed
@sethkfman sethkfman deleted the hotfix/ramp-networks-array-state branch April 10, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@metamaskbot metamaskbot added the release-7.19.1 Issue or pull request that will be included in release 7.19.1 label Apr 10, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.19.1 on PR, as PR was added to branch 7.19.1 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.1 Issue or pull request that will be included in release 7.19.1 Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants