-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add migration for linea goerli #9224
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 2371f52 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: at migration level doesn't need async state anymore if there is not async operations
Bitrise✅✅✅ Commit hash: ef9da94 Note
|
Quality Gate passedIssues Measures |
Description
PR to migrate users to linea Sepolia if they are on linea-goerli. And remove linea goerli from default network list because its deprecated.
Related issues
Fixes:
Manual testing steps
6.You should see deprecation warning for linea goerli. And you should be able to see any previous transactions you did.
Screenshots/Recordings
Before
Linea goerli appears on the default network list.
I make few transactions on both linea goerli and linea sepolia.
Screen.Recording.2024-04-12.at.18.20.51.mov
After
I add manually linea goerli and i can see transactions i already did.
Screen.Recording.2024-04-12.at.18.41.00.mov
Pre-merge author checklist
Pre-merge reviewer checklist