Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add migration for linea goerli #9224

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Apr 12, 2024

Description

PR to migrate users to linea Sepolia if they are on linea-goerli. And remove linea goerli from default network list because its deprecated.

Related issues

Fixes:

Manual testing steps

  1. Build on main
  2. Switch to linea-goerli
  3. Build on this PR
  4. You should be on linea sepolia instead of linea goerli
  5. You can add linea goerli by clicking on the navigation button in the wallet and type in: chainlist.org. Connect your wallet and you can look for the network you want to add then click on "add to metamask" button. (I used this RPc url https://59140.rpc.thirdweb.com to add linea goerli)
    6.You should see deprecation warning for linea goerli. And you should be able to see any previous transactions you did.

Screenshots/Recordings

Before

Linea goerli appears on the default network list.
I make few transactions on both linea goerli and linea sepolia.

Screen.Recording.2024-04-12.at.18.20.51.mov

After

I add manually linea goerli and i can see transactions i already did.

Screen.Recording.2024-04-12.at.18.41.00.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner April 12, 2024 15:33
@sahar-fehri sahar-fehri changed the title Fix/add migration for linea goerli Fix: add migration for linea goerli Apr 12, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri changed the title Fix: add migration for linea goerli fix: add migration for linea goerli Apr 12, 2024
@sahar-fehri sahar-fehri added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Apr 12, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2371f52
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d673fbb9-fa81-4074-b871-aea1aaf79cd6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart
NicolasMassart previously approved these changes Apr 12, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 12, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: at migration level doesn't need async state anymore if there is not async operations

app/store/migrations/038.ts Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ef9da94
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1993092-78fb-46c2-9cc1-2ecc1c2e0a87

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Apr 15, 2024

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024
@sahar-fehri sahar-fehri merged commit 547ca9d into main Apr 15, 2024
39 checks passed
@sahar-fehri sahar-fehri deleted the fix/add-migration-for-linea-goerli branch April 15, 2024 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 15, 2024
@salimtb salimtb added release-7.23.0 Issue or pull request that will be included in release 7.23.0 release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 release-7.23.0 Issue or pull request that will be included in release 7.23.0 labels May 3, 2024
@salimtb salimtb added release-7.24.0 Issue or pull request that will be included in release 7.24.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants