Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update the privacy policy url #9225

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Apr 12, 2024

Description

The previous link to the privacy policy was specific to metamask. It was decided (by legal team) that the consensys privacy policy should be shown.

Related issues

Fixes:

Manual testing steps

  1. Create a new account
  2. During the onboarding flow, at the privacy policy step, click the last link to show the updated privacy policy.
  3. There is also another place where this link is present Options->About Metamask->Privacy Policy

Screenshots/Recordings

Before (from settings menu) After (from settings menu) After (from onboarding flow)
Image 1 Image 2 Image 3

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the title feat(2215) Update the privacy policy url feat: Update the privacy policy url Apr 12, 2024
@EtherWizard33 EtherWizard33 added team-wallet-ux needs-smoke-e2e needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 12, 2024
@EtherWizard33
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@EtherWizard33 EtherWizard33 marked this pull request as ready for review April 15, 2024 18:00
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner April 15, 2024 18:00
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@EtherWizard33 EtherWizard33 requested review from frankvonhoven and removed request for frankvonhoven April 15, 2024 18:35
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@EtherWizard33 EtherWizard33 merged commit d9ea29d into main Apr 16, 2024
31 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2215-update-privacy-policy-url-1 branch April 16, 2024 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 16, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-smoke-e2e release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants