-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: smart-tx-small-logic #9442
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@9.1.0 |
That PR is still in draft and marked as cf 4a64a20 |
@legobeat That's a patch for an old version of the Perhaps @vinistevam can provide some more context as to what happens to patch PRs for the |
Yes, I was thinking perhaps the intention was to actually backport the changes in that PR for an I'm noting some divergence between the functions added here and their correspondents in upstream |
An alternative approach to this would be to first upgrade Just curious if this was considered and if there is some reason why the implementing towards the legacy version is preferred? That is to say, why not let this feature come after merge of #9088 and base the work on that branch? That would mean using a base of |
hey @legobeat , I don't have much context on the decision of the approach but I think this was considered, and the work on upgrading the I hope it clarified a bit more around the patch, let me know if you have any questions. 🙏 |
@legobeat Initially we didn't want to be dependent on a specific version of the |
1648c4c
to
2196f72
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Have to get the newest changes from #9565 |
Bitrise✅✅✅ Commit hash: e029bad Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the nit picks on previous comments and once the smart controller version is stored via redux!
LGTM
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
This reverts commit 4c144b3.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/swappable-obj-proxy@2.1.0 |
Bitrise✅✅✅ Commit hash: 0529bf3 Note
|
Quality Gate passedIssues Measures |
Description
This PR only covers a smaller subset of the files from #9565 for ease of reviewing. Please refer to that issue for videos. This PR is mostly for the core logical parts of Smart Transactions (STX). This PR can be merged as it won't change any existing behavior in the application without a follow up PR to actually use these utility functions.
It covers the following areas
/app/util
app/util/test/initial-background-state.json
,app/util/transactions/index.js
,app/util/transactions/index.test.ts
since it causes tests to fail/app/images
/e2e/selectors
app/core/RPCMethods/RPCMethodMiddleware.ts
(to fix tests)package.json
(Addedsmart-transactions-controller
to this PR to fix failing tests)app/components/Nav/Main/RootRPCMethodsUI.js
to fix failing tests@metamask+transaction-controller+13.0.0.patch
(https://github.com/MetaMask/core/compare/patch/mobile-transaction-controller-13-0-0-smart-transactions)yarn.lock
jest.config.js
Related issues
Manual testing steps
Refer to #9565
Screenshots/Recordings
Refer to #9565
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist