-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump controllers related accounts logic #9508
Conversation
…to refactor/encryptor-class
…k/metamask-mobile into refactor/encryptor-class
…Accounts Controller to v^11, this is still missing to check some breaking changes around the keyring controller v13
…r on engine and introduce the key for prefereces state change event on EngineService since now Preferences Controller extends BaseController v2
…es, patch preferences controller to export the etherscan supported chain ids to have sepolia and to be exported to the mobile app
Bug reported in original PR,
Follow up notes: This seems to be sporadic, as I have not been able to reproduce it with the same devices and the same 7.18.0 QA build like the initial observation. |
|
CONFIRMED NOT RELATED TO CHANGES IN THIS PR: When importing a valid private key by QR code, user is shown an error: "Invalid deeplink Invalid URL:" and the private key string is displayed in the error message. The account is successfully imported, but the error message is not appropriate in this scenario. ![]() Was observed with QA build from PR 9318, with multiple devices:
Steps:
UPDATE: This is present on main commit 6cc76b2 and is not related to the changes in this PR. This is not present on 7.21.0 build (production) but is present on the RC for 7.22.0. Opened a fresh issue. |
Tested migrations on Android 12, 14 and iOS 17.4.1 with Imported, Ledger and QR accounts present from both 7.18.0 (1268) as well as 7.19.0 (1292). Custom labels were preserved. Able to add and remove accounts as expected, change password and biometric auth, create new wallet, import an existing SRP in setup, import private keys after setup, and confirm SRP backup demand when value is added. Had some observations, but was not able to reproduce outside of the initial occurrence and looks like there have been subsequent changes in both 7.19.0 and 7.20.0 that may resolve the issues observed.
|
|
E2E failure not related to this branch since it's failing because of notification prompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The original PR is #9318. It was reverted and now the changes are being introduced in this new PR.
This PR updates several controllers that handle logic related to the wallet and accounts.
Some noteworthy points for this changes,
toChecksumHexAddress
and the function is the same on v^5 and on v^8ecnryptionLib
that way on the future we can create or import and we will not run the flow[recreateVaultWithSamePassword](https://github.com/MetaMask/metamask-mobile/blob/fcfa9d1bd03e16ba18f3e9919b85a854614c2377/app/core/Authentication/Authentication.ts#L110)
, since it was running unnecessarilyRelated issues
Manual testing steps
Screenshots/Recordings
Upgrade from main with Binance Smart Chain Selected, imported account with private key and tokens imported (Multiple chains added, and tokens imported on them also NFT imported on mainnet)
Screen.Recording.2024-04-24.at.13.01.08.mov
Pre-merge author checklist
Pre-merge reviewer checklist