Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opensea Popup #9514

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: Opensea Popup #9514

merged 2 commits into from
May 2, 2024

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented May 2, 2024

Issue: https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/metamask-mobile/9443

As a partial fix to the issue above, this will allow users to not encounter the reoccurring pop-up.

IMPORTANT: Accessing Opensea might still not always work, this fix will allow users to not be blocked.

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2024-05-02.at.19.43.31.mov

After

Samsung Galaxy s21 ultra Android 13:
Prod v7.20.1
https://github.com/MetaMask/metamask-mobile/assets/15312578/194ef756-934b-4175-a515-d6a0dda00751

Release 7.22
https://github.com/MetaMask/metamask-mobile/assets/15312578/bd81eab5-4dce-4b03-99f5-7aa295a7e442

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels May 2, 2024
@MarioAslau MarioAslau requested a review from sethkfman May 2, 2024 19:33
@MarioAslau MarioAslau self-assigned this May 2, 2024
@MarioAslau MarioAslau requested a review from a team as a code owner May 2, 2024 19:33
Copy link
Contributor

github-actions bot commented May 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau requested a review from 409H May 2, 2024 19:35
@MarioAslau MarioAslau added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 2, 2024
@MarioAslau MarioAslau removed the request for review from 409H May 2, 2024 19:36
Copy link
Contributor

github-actions bot commented May 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f8e22d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3370195e-6994-46db-9a2d-dc14d03d6093

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented May 2, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioAslau MarioAslau merged commit 6d9244e into main May 2, 2024
42 checks passed
@MarioAslau MarioAslau deleted the fix/opensea-popup branch May 2, 2024 20:13
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 2, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants