Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Opensea Popup #9514

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: Opensea Popup #9514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab71513
trust market: protocol to deeplink
jpcloureiro May 2, 2024
8f8e22d
feat: add log for protocol that is not allowed
MarioAslau May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/components/Views/BrowserTab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,7 @@ export const BrowserTab = (props) => {
// Continue request loading it the protocol is whitelisted
const { protocol } = new URL(url);
if (protocolAllowList.includes(protocol)) return true;
Logger.message(`Protocol not allowed ${protocol}`);

// If it is a trusted deeplink protocol, do not show the
// warning alert. Allow the OS to deeplink the URL
Expand All @@ -882,6 +883,9 @@ export const BrowserTab = (props) => {
return false;
}

// TODO: add logging for untrusted protocol being used
// Sentry
//
const alertMsg = getAlertMessage(protocol, strings);

// Pop up an alert dialog box to prompt the user for permission
Expand Down
1 change: 1 addition & 0 deletions app/util/browser/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export const trustedProtocolToDeeplink = [
'metamask:',
'ethereum:',
'dapp:',
'market:',
];

/**
Expand Down