-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update brandColors to be imported from design system #9875
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Will these need to be updated again for v4
? For example, brandColor.white000
to brandColor.white
, etc.?
- Checked for instances of removed white, black, and yellow colors ✅
Might be good to write a prefer-theme-color-object
rule in our eslint plugin to limit the use of the brandColor object. I'll create an issue
Bitrise✅✅✅ Commit hash: e502e97 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from platform side!
yes but that'll be more minor so prepping this first |
Description
This PR updates the brand color usage to be imported from the design-tokens repo. Additionally, it updates all existing instances of brand color usage (mainly QR codes and switches) to align with the schema defined in the design-tokens. This change ensures that the application consistently uses the brand colors specified by the design system, improving maintainability and visual coherence across the application.
Related issues
Fixes: #9874
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-05.at.13.21.41.mp4
Pre-merge author checklist
Pre-merge reviewer checklist