-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add send token button (link to TokenFactory) #1634
Merged
Merged
+439
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entering the address of a valid HumanStandardToken even auto-fills the other fields!
A simple solution to a temporary token send screen: Linking to EtherScan. Will hold us over until we make our own token send view.
danfinlay
added
blocked
DO-NOT-MERGE
Pull requests that should not be merged
in progress
labels
Jun 20, 2017
Addresses #784. |
We could change this when we allow hiding/removing tokens, but for now, this is a simple and pleasant solution.
…lugin into i1616-AddTokenAdding
…lugin into i1616-AddTokenAdding
tmashuang
approved these changes
Jun 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL:
Adds a
SEND
button to the token list items that navigate to the TokenFactory page for that token.We'll add our own send page later, but for now, it's a complete token UI to hold us over. Only thing I think it's missing is live your-balance display.