Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snap request processing queue #117

Closed
rekmarks opened this issue Nov 4, 2021 · 3 comments
Closed

Add Snap request processing queue #117

rekmarks opened this issue Nov 4, 2021 · 3 comments
Labels
status-wontfix This will not be worked on type-enhancement New feature or request

Comments

@rekmarks
Copy link
Member

rekmarks commented Nov 4, 2021

Once we have established a configurable Snap concurrency limit (#59), we should implement a queue for JSON-RPC requests for snaps that are stopped. As running snaps are stopped and concurrency "slots" (we have yet to pick a word for this) become available, snaps with queued requests should be started in a FIFO manner, and receive all of their requests once booted.
@rekmarks rekmarks mentioned this issue Nov 4, 2021
Closed
4 tasks
@rekmarks rekmarks changed the title Add request queue Add request processing queue Nov 4, 2021
@rekmarks rekmarks changed the title Add request processing queue Add Snap request processing queue Nov 4, 2021
@FrederikBolding
Copy link
Member

Related to #245 ?

@hmalik88
Copy link
Contributor

hmalik88 commented Mar 8, 2022

Yes, this looks to be a dupe. @rekmarks?

@ritave
Copy link
Member

ritave commented Sep 23, 2022

Browser's event queue handles this problem for us automatically today.

While we could consider adding a limit of waiting requests, this is not part of this issue so I'm closing it.

@ritave ritave closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2022
@ritave ritave added the status-wontfix This will not be worked on label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status-wontfix This will not be worked on type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FrederikBolding @ritave @rekmarks @hmalik88