Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set limit for number of concurrent snaps #59

Closed
rekmarks opened this issue Aug 19, 2021 · 2 comments
Closed

Set limit for number of concurrent snaps #59

rekmarks opened this issue Aug 19, 2021 · 2 comments
Labels
status-wontfix This will not be worked on type-enhancement New feature or request

Comments

@rekmarks
Copy link
Member

Per #56, we need some kind of limit on the concurrent number of snaps. We need to arrive at this number experimentally.
@rekmarks rekmarks mentioned this issue Aug 19, 2021
Closed
4 tasks
@rekmarks rekmarks added this to the Flask MVP milestone Aug 19, 2021
rekmarks pushed a commit that referenced this issue Sep 7, 2021
@dependabot
Bump ini from 1.3.5 to 1.3.8 in /examples/bls-signer (#59)
6e37b69 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Gudahtt
Copy link
Member

Gudahtt commented Sep 22, 2021

This should also encompass the work involved in handling the situation when we reach the limit of concurrent snaps (e.g. do we reject new snap requests? Queue them up? How large of a queue?)

@rekmarks rekmarks mentioned this issue Nov 4, 2021
Closed
@rekmarks rekmarks removed this from the Flask MVP milestone Nov 8, 2021
@ritave
Copy link
Member

ritave commented Sep 23, 2022

We've run a benchmark on ritave/onslaught branch and concluded that iframes can run 100+ snaps at the same time without any hiccups.

@ritave ritave closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2022
@ritave ritave added the status-wontfix This will not be worked on label Sep 23, 2022
@legobeat legobeat mentioned this issue Sep 9, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status-wontfix This will not be worked on type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shanejonas @ritave @Gudahtt @rekmarks