Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ephemeral lifecycle for Flask v1 #56

Closed
4 tasks done
rekmarks opened this issue Aug 19, 2021 · 1 comment
Closed
4 tasks done

Implement ephemeral lifecycle for Flask v1 #56

rekmarks opened this issue Aug 19, 2021 · 1 comment
Assignees

Comments

@rekmarks
Copy link
Member

rekmarks commented Aug 19, 2021

TODO

Future TODO

Specification

  • Under normal circumstances, MetaMask will never terminate a snap while it's processing a request, before the processing time limit has expired.
    • The processing time in v1 of the MVP will be on the order of 30-60 seconds.
  • MetaMask may terminate a snap immediately after the processing time limit has expired, or once processing has completed, which we define as when MetaMask observes the snap sending a response to a particular request.
  • Under abnormal circumstances, MetaMask may be forced to terminate a snap while it's processing a request, but will only do so if absolutely necessary.
    • Such circumstances include:
      • If the snap is consuming too many resources, where the threshold for "too many" may vary with the number of snaps running concurrently, and other factors.
      • If the snap "hangs" and its worker becomes unresponsive.
      • If the user force-quits the snap.
  • Regardless of when and how a snap is terminated, it should gracefully start back up.
    • If a snap's state becomes so corrupted that it cannot be restarted, the user may have limited options for resolving the matter, short of reinstalling the snap.
@rekmarks rekmarks added this to the Flask MVP milestone Aug 19, 2021
rekmarks pushed a commit that referenced this issue Sep 7, 2021
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 15.0.0 to 15.0.1.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rekmarks rekmarks changed the title Implement ephemeral lifecycle for the Flask MVP Implement ephemeral lifecycle for Flask v1 Nov 5, 2021
@rekmarks rekmarks removed this from the Flask MVP milestone Nov 8, 2021
@rekmarks
Copy link
Member Author

This was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants