Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support parameters in setTimeout and setInterval #2513

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

FrederikBolding
Copy link
Member

Tiny fix to support parameters in setTimeout and setInterval. This increases compatibility with ecosystem code that may use this functionality and was an oversight to not support initially.

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 24, 2024 12:52
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (8ab64ec) to head (7bcc577).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2513   +/-   ##
=======================================
  Coverage   94.38%   94.39%           
=======================================
  Files         441      441           
  Lines        9106     9109    +3     
  Branches     1405     1405           
=======================================
+ Hits         8595     8598    +3     
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 62dbfb6 into main Jun 24, 2024
156 checks passed
@FrederikBolding FrederikBolding deleted the fb/support-params-in-timeout-and-interval branch June 24, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants