Bureau landing page and Menu TM-1855 #1006
Conversation
src/Containers/Bureau/Bureau.jsx
Outdated
| getLogs: PropTypes.func, | ||
| getLogsList: PropTypes.func, | ||
| isLoading: PropTypes.bool, | ||
| logs: PropTypes.string, | ||
| logsIsLoading: PropTypes.bool, | ||
| logsHasErrored: PropTypes.bool, | ||
| logsList: PropTypes.arrayOf(PropTypes.string), | ||
| logsListIsLoading: PropTypes.bool, | ||
| logsListHasErrored: PropTypes.bool, | ||
| log: PropTypes.arrayOf(PropTypes.string), | ||
| logIsLoading: PropTypes.bool, | ||
| logHasErrored: PropTypes.bool, | ||
| logToDownload: PropTypes.string, | ||
| logToDownloadIsLoading: PropTypes.bool, | ||
| logToDownloadHasErrored: PropTypes.bool, | ||
| getLog: PropTypes.func, | ||
| getLogToDownload: PropTypes.func, | ||
| getSyncJobs: PropTypes.func, | ||
| syncJobs: PropTypes.arrayOf(PropTypes.shape({})), | ||
| syncJobsIsLoading: PropTypes.bool, | ||
| putAllSyncJobs: PropTypes.func, | ||
| putAllSyncsIsLoading: PropTypes.bool, | ||
| patchSyncIsLoading: PropTypes.bool, | ||
| patchSyncJob: PropTypes.func, | ||
| patchSyncHasErrored: PropTypes.bool, | ||
| getUsers: PropTypes.func, | ||
| getTableStats: PropTypes.func, | ||
| totalUsers: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.shape({})), | ||
| PropTypes.shape({ count: PropTypes.number })]), | ||
| fetchFeatureFlagsData: PropTypes.func, | ||
| featureFlags: PropTypes.shape({}), | ||
| }; | ||
|
|
||
| BureauContainer.defaultProps = { | ||
| getLogs: EMPTY_FUNCTION, | ||
| getLogsList: EMPTY_FUNCTION, | ||
| isLoading: false, | ||
| logs: '', | ||
| logsIsLoading: false, | ||
| logsHasErrored: false, | ||
| logsList: [], | ||
| logsListIsLoading: false, | ||
| logsListHasErrored: false, | ||
| log: [], | ||
| logIsLoading: false, | ||
| logHasErrored: false, | ||
| logToDownload: '', | ||
| logToDownloadIsLoading: false, | ||
| logToDownloadHasErrored: false, | ||
| getLog: EMPTY_FUNCTION, | ||
| getLogToDownload: EMPTY_FUNCTION, | ||
| getSyncJobs: EMPTY_FUNCTION, | ||
| syncJobs: [], | ||
| syncJobsIsLoading: false, | ||
| putAllSyncsIsLoading: false, | ||
| putAllSyncJobs: EMPTY_FUNCTION, | ||
| patchSyncIsLoading: false, | ||
| patchSyncJob: EMPTY_FUNCTION, | ||
| patchSyncHasErrored: false, | ||
| getUsers: EMPTY_FUNCTION, | ||
| getTableStats: EMPTY_FUNCTION, | ||
| totalUsers: {}, | ||
| fetchFeatureFlagsData: EMPTY_FUNCTION, | ||
| featureFlags: {}, | ||
| }; | ||
|
|
||
| const mapStateToProps = state => ({ | ||
| logs: state.logsSuccess, | ||
| logsIsLoading: state.logsIsLoading, | ||
| logsHasErrored: state.logsHasErrored, | ||
| logsList: state.logsListSuccess, | ||
| logsListIsLoading: state.logsListIsLoading, | ||
| logsListHasErrored: state.logsListHasErrored, | ||
| log: state.logSuccess, | ||
| logIsLoading: state.logIsLoading, | ||
| logHasErrored: state.logHasErrored, | ||
| logToDownload: state.logToDownloadSuccess, | ||
| logToDownloadIsLoading: state.logToDownloadIsLoading, | ||
| logToDownloadHasErrored: state.logToDownloadHasErrored, | ||
| syncJobs: state.syncs, | ||
| syncJobsIsLoading: state.syncsIsLoading, | ||
| putAllSyncsIsLoading: state.putAllSyncsIsLoading, | ||
| patchSyncIsLoading: state.patchSyncIsLoading, | ||
| patchSyncHasErrored: state.patchSyncHasErrored, | ||
| totalUsers: state.usersSuccess, | ||
| featureFlags: state.featureFlags, | ||
| }); | ||
|
|
||
| export const mapDispatchToProps = dispatch => ({ | ||
| getLogs: () => dispatch(getLogs()), | ||
| getLogsList: () => dispatch(getLogsList()), | ||
| getLog: id => dispatch(getLog(id)), | ||
| getLogToDownload: id => dispatch(getLogToDownload(id)), | ||
| getSyncJobs: () => dispatch(syncsFetchData()), | ||
| putAllSyncJobs: () => dispatch(putAllSyncs()), | ||
| patchSyncJob: data => dispatch(patchSync(data)), | ||
| getUsers: () => dispatch(getUsers()), | ||
| getTableStats: () => dispatch(getTableStats()), | ||
| fetchFeatureFlagsData: () => dispatch(fetchFeatureFlagsData()), | ||
| }); |
There was a problem hiding this comment.
Let's remove all the copied state values and actions
There was a problem hiding this comment.
Oops! Missed those, thanks! Will do!
src/Containers/Bureau/Bureau.jsx
Outdated
| import { syncsFetchData, putAllSyncs, patchSync } from '../../actions/synchronizations'; | ||
| import { EMPTY_FUNCTION } from '../../Constants/PropTypes'; | ||
|
|
||
| export const downloadFile = (text) => { |
There was a problem hiding this comment.
Let's also remove all the copied over functions
src/Constants/Menu.js
Outdated
| ], | ||
| }, | ||
| { | ||
| text: 'Position Manager', |
There was a problem hiding this comment.
Let's increase the width of the menu so that this isn't so close to the edge
| // onSelectOption={myFunction} | ||
| /> | ||
| </div> | ||
| <div className="usa-width-one-whole"> |
There was a problem hiding this comment.
I think if we end up going with data viz here, it will be abstracted out to a data viz library. I think this is valuable to keep for demo purposes, but we will need to wrap it in a static content feature flag so that it doesn't appear in the DOS environment
There was a problem hiding this comment.
Hopefully D3! For sure, I think it helps get the imagination going. Ok, will do :)
src/Constants/Menu.js
Outdated
| @@ -169,6 +169,50 @@ export const GET_PROFILE_MENU = () => MenuConfig([ | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| text: 'Bureau', | |||
| route: '/profile/bureau/', | |||
There was a problem hiding this comment.
If you change this to route: '/profile/bureau/dashboard/',, it will be clickable in the condensed menu
There was a problem hiding this comment.
changed to route: '/profile/bureau/positionlists/' since that's going to be our "default" for now. Didn't really see a change tho :/
|
Looks good. Overall comments:
|
Do you think I should create a feature flag for each menu item, or one for the whole Bureau menu, or both? |
Ultimately that Bureau landing page won't be used in the first pass. I think what I'd do is set the "default" view to the Positions List since that's the first bit of functionality we'll be completing. Then just feature flag the menu links that we won't use with the existing static_content flag. |
Gotcha! Will do :) |
|
🙈 dont check on small screen! |
elizabeth-jimenez
changed the title
No description provided.