TM-6124-Projected-Vacancies-UI #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagbakwu
requested review from
M00staff,
elizabeth-jimenez,
scott062 and
jlam-mpc
… into TM-6124-Projected-Vacancies-Expose-Read
M00staff
reviewed
Jun 11, 2024
| @@ -308,6 +309,7 @@ const ProjectedVacancyCard = (props) => { | |||
| <PositionExpandableContent | |||
| sections={sections} | |||
| form={form} | |||
| tempHideEdit={isAO} | |||
There was a problem hiding this comment.
the ticket asked to hide the edit button - not to disable it, added this in for ya!
M00staff
reviewed
Jun 11, 2024
src/Constants/Menu.js
Outdated
| icon: ' fa-keyboard-o', | ||
| roles: [ | ||
| 'superuser', | ||
| 'bureau_user', |
There was a problem hiding this comment.
i think this should have been ao_user
... ill take care of it - tinkering with a few other things as well!
There was a problem hiding this comment.
surprised this worked for you locally?
there's a weird bug where you have to log out and back in twice locally to make sure your permissions come out correct.
There was a problem hiding this comment.
@M00staff I may have to clear my cache when reloading.
M00staff
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Merge:
Ticket