TM-6124-Projected-Vacancies-API #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagbakwu
requested review from
M00staff,
elizabeth-jimenez,
scott062 and
jlam-mpc
|
These are the wrong endpoints |
That's my bad! I assumed because the names were the same...Ill resolve it now. |
…b.com/MetaPhase-Consulting/State-TalentMAP-API into TM-6124-Projected-Vacancy-Expose-Read
cagbakwu
commented
Jun 11, 2024
| @@ -19,7 +19,7 @@ class FSBidAdminProjectedVacancyFiltersView(APIView): | |||
|
|
|||
| # ======================== Get PV Filters ======================== | |||
|
|
|||
| permission_classes = [IsAuthenticated, Or(isDjangoGroupMember('bureau_user'), isDjangoGroupMember('superuser'), ) ] | |||
There was a problem hiding this comment.
Only required for the READ requests
|
Just realized I used projected_vacancies instead of admin_projected_vacancies 🤦🏾♂️ |
|
this looks right - did you double check & log in as an AO to make sure everything works? sometimes you need to log out and log in twice locally to get the permissions to change |
|
still a WiP? 
|
M00staff
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Merge:
Ticket