Pv testing bugdfix #3018
Merged
Pv testing bugdfix #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2024 11:33
jlam-mpc
reviewed
Jun 12, 2024
src/Components/AoPage/AoPage.jsx
Outdated
| @@ -26,7 +26,7 @@ const AoPage = () => ( | |||
| <Route path="/profile/ao/availablebidders" render={() => <AvailableBidderContainer isCDO={false} isAO />} /> | |||
| <Route path="/profile/ao/panelmeetingagendas/:pmID" render={() => <PanelMeetingAgendas isAO />} /> | |||
| <Route path="/profile/ao/cyclemanagement" render={() => <CycleManagement isAO />} /> | |||
| <Route path="/profile/ao/projectedvacancy" render={() => <ProjectedVacancy isCDO={false} isAO />} /> | |||
| <Route path="/profile/ao/projectedvacancy" render={() => <ProjectedVacancy isCDO={false} isAO viewType="ao" />} /> | |||
There was a problem hiding this comment.
I think we should scrap the isAO prop since you have this new one
There was a problem hiding this comment.
I removed that prop in the PV components but forgot to remove it here
You new prop is a lot more descriptive than isAO, but I think the isAO prop can handle what you're aiming to do as well if you just pull that into the ProjectedVacancy components. Just leave it and delete "isAO"
There was a problem hiding this comment.
wow - just realized it literally wasn't doing anything cause this guy
There was a problem hiding this comment.
also dont need the isCDO={false} bit either - not used lol
jlam-mpc
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.