Pv testing bugdfix

src/Components/AoPage/AoPage.jsx

@@ -26,7 +26,7 @@ const AoPage = () => (
       <Route path="/profile/ao/availablebidders" render={() => <AvailableBidderContainer isCDO={false} isAO />} />
       <Route path="/profile/ao/panelmeetingagendas/:pmID" render={() => <PanelMeetingAgendas isAO />} />
       <Route path="/profile/ao/cyclemanagement" render={() => <CycleManagement isAO />} />
-      <Route path="/profile/ao/projectedvacancy" render={() => <ProjectedVacancy isCDO={false} isAO />} />
+      <Route path="/profile/ao/projectedvacancy" render={() => <ProjectedVacancy viewType="ao" />} />
       <Route path="/profile/ao/assignmentcycle/:id" render={() => <AssignmentCycleEdit isAO />} />
       <Route path="/profile/ao/cyclepositionsearch/:id" render={() => <CyclePositionSearch isAO />} />
       <Route path="/profile/ao/cycleclassifications/" render={() => <CycleClassifications isAO />} />

src/Components/BureauPage/BureauPage.jsx

@@ -28,7 +28,7 @@ const BureauPage = () => {
         <Route path="/profile/bureau/managepostaccess" render={() => <ManagePostAccess />} />
         <Route path="/profile/bureau/positionmanager/:type/:id" render={() => <PositionManagerDetails />} />
         <Route path="/profile/bureau/positionmanager" render={() => <PositionManager {...posManagerProps} />} />
-        <Route path="/profile/bureau/projectedvacancy" render={() => <ProjectedVacancy isCDO={false} isAO={false} />} />
+        <Route path="/profile/bureau/projectedvacancy" render={() => <ProjectedVacancy viewType="bureau" />} />
         <Route path="/profile/bureau/publishablepositions" render={() => <PublishablePositions viewType="bureau" />} />
         <Route path="/profile/bureau/searchpostaccess" render={() => <SearchPostAccess />} />
         <Route path="/profile/bureau/biddingtool/:id" render={() => <BiddingTool />} />

src/Components/BureauPage/ProjectedVacancy/ProjectedVacancy.jsx

@@ -11,7 +11,6 @@ import {
   projectedVacancyFetchData,
   projectedVacancyFilters,
   projectedVacancyLangOffsetOptions,
-  // projectedVacancyLangOffsets,
   saveProjectedVacancySelections,
 } from 'actions/projectedVacancy';
 import { onEditModeSearch, renderSelectionList, userHasPermissions } from 'utilities';
@@ -29,12 +28,14 @@ const enableCycleImport = () => checkFlag('flags.projected_vacancy_cycle_import'
 const enableEdit = () => checkFlag('flags.projected_vacancy_edit');
 
 // eslint-disable-next-line complexity
-const ProjectedVacancy = () => {
+const ProjectedVacancy = ({ viewType }) => {
   const dispatch = useDispatch();
 
   const userProfile = useSelector(state => state.userProfile);
   const isAo = userHasPermissions(['ao_user'], userProfile?.permission_groups);
   const isBureau = userHasPermissions(['bureau_user'], userProfile?.permission_groups);
+  const bureauPermissions = useSelector(state => state.userProfile.bureau_permissions);
+  const isBureauView = viewType === 'bureau';
 
   const userSelections = useSelector(state => state.projectedVacancySelections);
   const filters = useSelector(state => state.projectedVacancyFilters) || [];
@@ -78,7 +79,28 @@ const ProjectedVacancy = () => {
   const [selectedCycle, setSelectedCycle] =
     useState(userSelections?.selectedCycle || null);
 
-  const bureaus = sortBy(filters?.bureaus || [], [o => o.description]);
+  const getBureauFilters = () => {
+    const originalBureaus = sortBy(filters?.bureaus || [], [o => o.short_description]);
+    if (originalBureaus && isBureauView) {
+      const bureauPermissionsGroups = Object.groupBy(bureauPermissions, ({ short_description }) => short_description);
+      const userBureauDescPermissions = Object.keys(bureauPermissionsGroups);
+      // filter out if user does not have that bureau permission
+      return originalBureaus.filter((a) => userBureauDescPermissions.includes(a?.short_description));
+    }
+    return originalBureaus;
+  };
+
+  const filterSelectionValid = () => {
+    // valid if:
+    // not Bureau user
+    // a Bureau filter selected
+    if (viewType === 'bureau') {
+      return selectedBureaus.length > 0;
+    }
+    return true;
+  };
+
+  const bureaus = getBureauFilters();
   const grades = sortBy(filters?.grades || [], [o => o.code]);
   const skills = sortBy(filters?.skills || [], [o => o.description]);
   const languages = sortBy(filters?.languages || [], [o => o.description]);
@@ -140,6 +162,8 @@ const ProjectedVacancy = () => {
       overlay = <Spinner type="standard-center" class="homepage-position-results" size="big" />;
     } else if (resultsErrored) {
       overlay = <Alert type="error" title="Error displaying Projected Vacancies" messages={[{ body: 'Please try again.' }]} />;
+    } else if (!filterSelectionValid()) {
+      overlay = <Alert type="info" title="Select Bureau Filter" messages={[{ body: 'Please select a Bureau Filter.' }]} />;
     } else if (!positionsData?.results?.length) {
       overlay = <Alert type="info" title="No results found" messages={[{ body: 'No projected vacancies for filter inputs.' }]} />;
     } else {
@@ -187,11 +211,13 @@ const ProjectedVacancy = () => {
     } else {
       setClearFilters(true);
     }
-    if (resetPage) {
-      setPage(1);
+    if (filterSelectionValid()) {
+      if (resetPage) {
+        setPage(1);
+      }
+      dispatch(projectedVacancyFetchData(getQuery()));
+      dispatch(saveProjectedVacancySelections(getCurrentInputs()));
     }
-    dispatch(projectedVacancyFetchData(getQuery()));
-    dispatch(saveProjectedVacancySelections(getCurrentInputs()));
   };
 
   useEffect(() => {
@@ -353,7 +379,7 @@ const ProjectedVacancy = () => {
                 disabled={disableInput}
               />
             </div>
-            {enableCycleImport &&
+            {enableCycleImport() &&
               <div className="filter-div">
                 <div className="label">Cycle:</div>
                 <Picky
@@ -474,6 +500,7 @@ const ProjectedVacancy = () => {
 
 
 ProjectedVacancy.propTypes = {
+  viewType: PropTypes.string.isRequired,
   bureauFiltersIsLoading: PropTypes.bool,
 };