update endpoints for reference data/filters #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think what I'll do is duplicate these objects, add another property similar to |
|
Wrapped new endpoints in feature flag. Ready for review @rtirserio @scott062 |
|
Tested everything and the correct requests are going out to the FSBid api. However, user testing the new filters is spotty with the current mock data. @rtirserio Is this PR good to go, or do we need to wait for mock data updates etc.? |
* dev: Lock into jest-unit@8.0.0 because of node version Remove assignments endpoint since it no longer exists Use browser detection to disable dark mode in IE11, since it breaks Add spinner to results filters while loading # Conflicts: # src/utilities.js
mjoyce91
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do NOT merge until api is merged and toggle flag is added