-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetacelloAbstractVersionConstructor>>projectForVersion:copyFrom:with: not correct when applied to a project using MetacelloCypressBaselineProject project class #531
Closed
dalehenrich opened this issue
Oct 8, 2020
· 2 comments
· Fixed by dalehenrich/metacello-work#6 or #532
Closed
MetacelloAbstractVersionConstructor>>projectForVersion:copyFrom:with: not correct when applied to a project using MetacelloCypressBaselineProject project class #531
dalehenrich opened this issue
Oct 8, 2020
· 2 comments
· Fixed by dalehenrich/metacello-work#6 or #532
Comments
9 tasks
dalehenrich
added a commit
to dalehenrich/metacello-work
that referenced
this issue
Oct 8, 2020
It turns out that the reason this shows up is that the projectClass for the copied spec is picked up from the current baseline, not the one that is being copied! ... that explains why the change to BaseilineOfSeaside caused the merge conflict for Grease. |
dalehenrich
added a commit
to dalehenrich/metacello-work
that referenced
this issue
Oct 8, 2020
dalehenrich
added a commit
to dalehenrich/metacello-work
that referenced
this issue
Oct 8, 2020
Metacello/Metacello needs this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MetacelloAbstractVersionConstructor>>projectForVersion:copyFrom:with: does not create a new project using the baseline's project class ... and it should ...
Interestingly enough, this bugs happens to have been expose when I changed the projectClass for BaselineOfSeaside.
Why this was exposed when I changed the projectClass for BaselineOfSeaside is a good question, but Seaside does happen to use:
and this bug did not appear until I made the change ... More revealed as I dendeavor to fix this bug.
Here's the stack:
The text was updated successfully, but these errors were encountered: