Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BouncyCastle #130

Closed
lontivero opened this issue Oct 4, 2015 · 5 comments
Closed

Remove BouncyCastle #130

lontivero opened this issue Oct 4, 2015 · 5 comments
Labels

Comments

@lontivero
Copy link
Contributor

@NicolasDorier, I've been working hard for days now trying to remove BC but I hit the wall because I didn't follow a refactoring plan and it was a lot harder than what I thought. However, I think it could worth the effort (I really don't like to have two projects: BC and BC portable in NBitcoin).

There is a very little library that we could use: Secp256k1 It has all what NBitcoin needs.

Do you think it is a good idea and worth? If so, do you have any idea about how could we start the refactoring?

@NicolasDorier
Copy link
Collaborator

I would like also to be honest. But I don't think it is possible, don't forget that the portable lib depends even more of BC for some encryption/hash purposes. I don't think it will be easy.

@NicolasDorier
Copy link
Collaborator

Secp256k1 is not enough sadly.
Secp only check signatures, Bitcoin need other stuff like SHA calculation, DES, AES, and need to work in portable lib where you can't use MS security layer.

@bitcoinbrisbane
Copy link
Contributor

I too like the idea. However, its a big risk. Bouncy is has been in the wild for a long time. Before this project, I tried to code everything myself (just for the challenge) and found myself just using BC in the end.

@lontivero
Copy link
Contributor Author

I agree with you both. A lot of risky work just to end writting our own crypto library. It doesn't worth. Thank you.

@andreabenetton
Copy link
Contributor

I have noticed Legion of Bouncycastle release a
Release 1.8.1, 28th December 2015

A verification of fixed bug/issue should be done against feature used by
NBitcoin.

Andrea

On 5 January 2016 at 07:11, Lucas Ontivero notifications@github.com wrote:

I agree with you both. A lot of risky work just to end writting our own
crypto library. It doesn't worth. Thank you.


Reply to this email directly or view it on GitHub
#130 (comment).

dalijolijo added a commit to dalijolijo/NBitcoin that referenced this issue Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants