Add Gincoin (safe code only) #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBitcoin.Tests/NodeBuilderEx.cs
Outdated
| //var builder = NodeBuilder.Create(NodeDownloadData.Liquid.v3_14_1_21, Altcoins.AltNetworkSets.Liquid.Regtest, caller); | ||
| //var builder = NodeBuilder.Create(NodeDownloadData.Bitcore.v0_15_2, Altcoins.Bitcore.Instance.Regtest, caller); | ||
| var builder = NodeBuilder.Create(NodeDownloadData.Gincoin.v1_1_0_0, Altcoins.Gincoin.Instance.Regtest, caller); |
There was a problem hiding this comment.
comment this and uncomment Bitcoin
NBitcoin.sln
Outdated
| @@ -18,6 +18,10 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NBitcoin.Altcoins", "NBitco | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NBitcoin.TestFramework", "NBitcoin.TestFramework\NBitcoin.TestFramework.csproj", "{653C0F21-25FE-4B72-95AC-20D070A45415}" | |||
| EndProject | |||
There was a problem hiding this comment.
remove changes in this file.
.gitmodules
Outdated
| @@ -0,0 +1,3 @@ | |||
| [submodule "Submodules/Lyra2"] | |||
|
No submodule, duplicate the code if needed. And fix the build. |
|
Done. Thanks for the review Nicolas! |
|
@kkabala Gincoin mainnet Magic is: 0xBD6B0CBF |
|
You're right @eabz . Already fixed, thanks! |
| { | ||
| public static class Consensus | ||
| { | ||
| public const int LYRA2Z_TIMESTAMP = 1525651200; //7 May 2018 @ midnight UTC |
There was a problem hiding this comment.
Remove this, just hardcode where you use it
| DownloadLink = | ||
| "https://github.com/gincoin-dev/gincoin-core/releases/download/{0}.0/gincoincore-{0}-linux-64bit.tar.gz", | ||
| Archive = "gincoincore-{0}-linux-64bit.tar.gz", | ||
| Executable = "gincoincore-{0}-linux-64bit/bin/dashd", |
|
@NicolasDorier could you re-run AppVeyor build? It doesn't seem that any of my last 2 commits is able to make this unit test fail and before everything was built successfully. |
|
OK, everything seems to be ok now with builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 7 May 2018 Gincoin was using Neoscrypt instead of Lyra2Z. For now commented out that part as there are no safe Neoscrypt implementation (same way as for Mogwai).
Probably in the future I'll try to rewrite neoscrypt also.