Release 1.0.0 #138
Merged
Release 1.0.0 #138
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been supported for some time; recognize that at last. Signed-off-by: Keith Wansbrough <Keith.Wansbrough@metaswitch.com>
angusi
approved these changes
Mar 30, 2022
| https://downloads.datastax.com/cpp-driver/ubuntu/18.04/dependencies/libuv/v1.35.0/libuv1-dev_1.35.0-1_amd64.deb \ | ||
| https://downloads.datastax.com/cpp-driver/ubuntu/18.04/cassandra/v2.15.3/cassandra-cpp-driver_2.15.3-1_amd64.deb \ | ||
| https://downloads.datastax.com/cpp-driver/ubuntu/18.04/cassandra/v2.15.3/cassandra-cpp-driver-dev_2.15.3-1_amd64.deb && \ | ||
| wget https://downloads.datastax.com/cpp-driver/ubuntu/18.04/dependencies/libuv/v1.23.0/libuv1_1.23.0-1_amd64.deb \ |
There was a problem hiding this comment.
Thi versions number's gone backwards. Is that correct?
There was a problem hiding this comment.
Yes, this is a library so we want minimal dependencies. So we test with the oldest supported version of each library. The workflow build.yml has this correct, but for some reason floki.yaml was not. This fixes that.
Cassandra has to be 2.16.0 or greater to support the recent additions for Astra (cloud secure connection).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been supported for some time; recognize that at last.
Also update floki file to match the GitHub actions file - use the required Cassandra driver version.
Also update CHANGELOG which was out of date.