Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.rkt to add category #69

Merged
merged 3 commits into from Jul 11, 2023
Merged

Conversation

spdegabrielle
Copy link
Contributor

Update info.rkt scribblings parameter to add "DrRacket Plugin" category.

Update info.rkt scribblings parameter to add "DrRacket Plugin" category.
@Metaxal
Copy link
Owner

Metaxal commented Jul 2, 2023

Hey Stephen, I'm not entirely clear what this change is supposed to be doing. Can you clarify?

@spdegabrielle
Copy link
Contributor Author

Adds quickscript to the DrRacket Plugins category on docs.racket-lang.org
via the third parameter in scribblings https://docs.racket-lang.org/raco/setup-info.html#%28idx._%28gentag._16._%28lib._scribblings%2Fraco%2Fraco..scrbl%29%29%29

@Metaxal
Copy link
Owner

Metaxal commented Jul 10, 2023

This commit doesn't seem to work:

raco-local: WARNING: bad 'scribblings info: '(("scribblings/quickscript.scrbl" () (tool "DrRacket Plugin") "quickscript")) 

I'm not sure what was wrong with the previous state though? Quickscript was already in the Tools section.

@spdegabrielle
Copy link
Contributor Author

The goal is to make the top level of docs.racket-lang.org

i made a couple of dozen PR’s in different packages - unfortunately yours is one of two where I made a mistake.

i’ve fixed the PR but but you may disagree with my categorisation.

@spdegabrielle
Copy link
Contributor Author

since I posted this one of my PR’s has been accepted:

racket/racket#4687
Superseding the change

@Metaxal
Copy link
Owner

Metaxal commented Jul 10, 2023

@sorawee mentions the category should be "DrRacket Plugins" (plural) instead. WDYT?

@spdegabrielle
Copy link
Contributor Author

The symbol in singular maps to the heading in plural
(drracket-plugin "DrRacket Plugins")

this is the convention
in pkgs/racket-index/scribblings/main/config.rkt

@sorawee
Copy link

sorawee commented Jul 11, 2023

Actually, one thing that I forgot to think about is backward compatibility for Quickscript w.r.t. the drracket-plugin symbol. 'drracket-plugin will work fine for Racket 8.10, but it's unclear what will happen in prior versions. Can you test?

@spdegabrielle
Copy link
Contributor Author

I've given https://pkgd.racket-lang.org/pkgn/package/Coroutines a non-existent category symbol.
We will see how it goes.

(define scribblings
  (list (list "coroutines.scrbl"
              (list 'multi-page)
              (list 'concurrency)
              "coroutines")))

@Metaxal
Copy link
Owner

Metaxal commented Jul 11, 2023

On Racket 8.9.0.5, this is how it appears:
image
I guess there's an automatic camel case based on the symbol? 🤔

@Metaxal Metaxal merged commit 5911de8 into Metaxal:master Jul 11, 2023
@sorawee
Copy link

sorawee commented Jul 11, 2023

@Metaxal it looks like you are testing against the first commit of this PR, but the PR has since been updated to use a symbol instead. Can you try again?

@Metaxal
Copy link
Owner

Metaxal commented Jul 11, 2023

This is weird. My quickscript/info.rkt says:

(define scribblings '(("scribblings/quickscript.scrbl" () (drracket-plugin) "quickscript")))

so I tried to change it to

(define scribblings '(("scribblings/quickscript.scrbl" () (drracket-pluginnnn) "quickscript")))

but this had no effect. Tried reloading the page and ignoring the cache, same thing. There may be something wrong with my Racket install.

Edit: raco pkg show -l | grep quickscript also shows the correct directory...
Edit 2: raco setup quickscript && raco setup --doc-index && raco docs same story
Edit 3: This is getting weirder. I managed to finally trigger an update of the doc main page by removing another package, but not by setup quickscript even followed by raco setup --doc-index. Changing the QS docs does work though, it's just the top page that isn't updated.

@Metaxal
Copy link
Owner

Metaxal commented Jul 12, 2023

Apparently if the category is wrong, it just puts the docs back into "Misc", but since I can't manage to trigger the update of the top page it's complicated to test.

@rfindler
Copy link
Collaborator

rfindler commented Jul 13, 2023 via email

@Metaxal
Copy link
Owner

Metaxal commented Jul 13, 2023

Ah, finally! Deleting index.html and raco setup --doc-index works, thanks @rfindler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants