-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminology correction: alt -> height #113
Conversation
Hey @regDaniel, Here is the PR as discussed. I'll let you decide whether you prefer to merge it right away into As mentioned above, this PR is purely "cosmetic" and does not change the functionality of the code in anyway - however, it does break the user interface (the naming convention for the input Pandas DataFrame has changed). I figured you'd decide what version bump was appropriate directly in your NSC update ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this rather tedious work @fpavogt ! I have nothing to add and will rebase this into my branch once it's merged.
On second thought... It's probably easier to merge my PR first as it's more localized and then rebase this one. I'll take care of it. |
Sounds good. Should we bump the code version in this PR then ? I'd suggest to bump it to 1.1.0 ? |
Yes we should, but I wonder whether we'd even need a major upgrade to 2.0 as the changes are somewhat breaking. In any case, I can take care of it if you want. |
… 'extras' in setup.py for dev work
Description:
This PR implements a series of cosmetic changes to use height instead of altitude throughout the code. This is to reflect the fact that ceilometer hits and MSA are/must be both specified in ft above aerodrome level.
Although these changes are cosmetic, they will impact the end users, as the naming convention for the input Pandas DataFrame has changed, with the
alt
column now beingheight
.No version changes is included in this PR, but one should definitely raise it before making a new release to reflect this backward-incompatibly evolution.
In addition, this PR includes two additional minor changes:
setup.py
, to take into account the fact thatsetuptools
must be explicitly requested as anextras
package for dev work as of Python 3.12Error(s) fixed:
Checklists: