Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop fol #83

Closed
wants to merge 14 commits into from
Closed

Develop fol #83

wants to merge 14 commits into from

Conversation

loforest
Copy link
Collaborator

@loforest loforest commented Sep 22, 2022

Description:

This PR solves a small bug, simplifies one calculation and adds two extensions to the algorithm:

  • Bug: the LAYER_BASE_FRAC was not passed to the metarize method, so changing this parameter had no effect.
  • Simplification: the parameter LAYER_BASE_FRAC was renamed LAYER_BASE_PERC, but has now a different behaviour. Instead of computing the layer height as the median of the lowest percentage of cloud heights, it is sopmuted as a given percentile. You obtain the same behaviour as before by setting LAYER_BASE_PERC = LAYER_BASE_FRAC*100/2
  • Extension 1: calculation of cloud layer height as percentile of the most recent cloud hits instead of the whole time interval. This allows reducing the height underestimation of layers whose height is gradually increasing.
  • Extension 2: merging of too close layers was introduced also in the grouping and slicing steps (not only the layering). In addition, the minimum separation parameters can be specified according to height ranges. This reduces the amount of algorithm overlayering, which was sometimes producing two FEW layers rather than one BKN layer (especially at high heights).

This PR is not yet finished: extension 2 does not work yet as specified and tests need to be added. Also, some tests did not pass, e.g. due to moving out from the layering step the AmpycloudWarning for too close layers.

Error(s) fixed:

Please tag them using #, e.g. Fixed #42.

Checklists:

  • New code includes dedicated tests.
  • New code has been linted.
  • New code follows the project's style.
  • New code is compatible with the 3-Clause BSD license.
  • CHANGELOG has been updated.
  • AUTHORS has been updated.
  • Copyright years in module docstrings have been updated.

@loforest loforest marked this pull request as draft September 22, 2022 13:55
@fpavogt fpavogt marked this pull request as ready for review October 20, 2022 15:57
@fpavogt
Copy link
Member

fpavogt commented Oct 20, 2022

This PR has become obsolete in view of #86. I'll close it.

@fpavogt fpavogt closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants