-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New overlapping criteria, fluffiness, and prm cleanup #86
Conversation
Pandas v2.x compatibility cleanup
Hey @loforest, @regDaniel, @pjuda, @sibalm - fyi, this PR is now ready once again to have its scientific stability/validity evaluated. I have just merged #101 into it (which included a handful of small "logistical" Actions/Tests tweaks) so that all the tests are now green again. Happy to talk live about the stability tests when you want, and in particular the necessity (maybe?) to fine-tune some of the parameters (old and new). Side-note: the pytest action will be triggered twice per week as soon as this gets merged into |
Fix Issue 18
|
||
# Run the code | ||
out = run(data) | ||
assert out.metar_msg() == 'SCT020' | ||
assert out.metar_msg() == 'NCD' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be a minimal test case with an output which is not NCD but actually some cloud layers identified?
Description:
This PR introduces a series of updates to the code, following the suggestions by @loforest in #83, including:
OKTA_LIM8
has been changed to99
following the large scale tests of @loforest.manhattan
toeuclidean
, since the former is detrimental to rising/dropping layers.min/max +- alt_pad_perc * (thickness)
.alt_pad_perc
is a new ampycloudGROUPING
parameter that replacesoverlap
!metarize
routine now also computes the "fluffiness" of layers (see Compute the fluffiness of cloud layers #89). This requires to addscipy
andstatsmodels
to the list of required dependencies.OKTA_LIM0
has been replaced byMAX_HITS_OKTA0
, which now specifies the maximum (absolute) number of hits in a given slice/group/layer for it to be considered to be 0 oktas.OKTA_LIM8
has been replaced byMAX_HOLES_OKTA8
, which now specifies the maximum (absolute) number of holes (= non-detection of cloud bases) in a given slice/group/layer for it to be considered to be 8 oktas.It also contains other less critical changes, including:
step_scale()
Error(s) fixed:
Fixes #85 (scientific validity tests are now always run fully, even if one fails). Fixes #84. Fixes #89. Fixes #90. Fixes #87. Fixes #92. Fixes #98.
With the merging of #101 this also: fixes #102, fixes #95, fixes #100, fixes #93, and fixes #99.
Checklists: