New overlapping criteria, fluffiness, and prm cleanup

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,71 @@
+name: Bug Report
+description: Create a bug report to help us improve ampycloud
+title: "[Bug]: "
+labels: ["triage"]
+body:
+  - type: checkboxes
+    attributes:
+      label: Is there already an issue for this?
+      description: Look at the [open](https://github.com/MeteoSwiss/ampycloud/issues) and [closed](https://github.com/MeteoSwiss/ampycloud/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+) issues.
+      options:
+        - label: I found no existing issue for this bug.
+    validations:
+      required: true
+  - type: textarea
+    id: description
+    attributes:
+      label: Describe the bug
+      description: Tell us what happened and (if applicable) what you expected.
+      placeholder: Describe the bug
+      value: "A clear and concise description of what happened."
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Screenshot
+      description: |
+        If applicable, attach the ampycloud diagnostic plot by clicking this area to highlight it and then dragging the file in.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Steps to reproduce
+      description: Steps to reproduce the bug.
+      placeholder: |
+        1. In this environment...
+        2. With this config...
+        3. Run '...'
+        4. See error...
+    validations:
+      required: false
+  - type: textarea
+    id: logs
+    attributes:
+      label: Relevant log output
+      description: |
+        Copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
+        See the [ampycloud documentation](https://meteoswiss.github.io/ampycloud/running.html#logging) for instructions on how to enable logging.
+      render: shell
+  - type: textarea
+    attributes:
+      label: Environment
+      description: |
+        examples:
+          - **OS**: Ubuntu 20.04
+          - **Python**: 3.11.1
+          - **ampycloud**: 0.6.0dev0
+      value: |
+        - OS:
+        - Python:
+        - ampycloud:
+      render: markdown
+    validations:
+      required: false
+  - type: checkboxes
+    id: terms
+    attributes:
+      label: Code of Conduct
+      description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/MeteoSwiss/ampycloud/blob/develop/CODE_OF_CONDUCT.md).
+      options:
+        - label: I agree to follow the ampycloud Code of Conduct.
+          required: true

.github/ISSUE_TEMPLATE/todo.yml

@@ -0,0 +1,20 @@
+name: New Feature
+description: Keep track of an (approved) new feature of ampycloud
+title: "[New Feature]: "
+labels: ["todo"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This is to keep track of **dev-approved** changes.
+
+        To **suggest** a new feature instead, head over to the [ampycloud Github Discussions page](https://github.com/MeteoSwiss/ampycloud/discussions).
+
+  - type: textarea
+    id: description
+    attributes:
+      label: Describe the new feature
+      placeholder: Describe the feature
+      value: "A clear and concise description of what should be added to || modified in || removed from ampycloud."
+    validations:
+      required: true

.github/workflows/CI_check_version.yml

@@ -6,7 +6,7 @@
 # 10.0.1, 10.0.2.dev0 is valid
 # 10.0, 10, is NOT valid !
 #
-# Copyright (c) 2022 fpavogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2022-2023 fpavogt; frederic.vogt@meteoswiss.ch
 
 name: CI_check_version
 
@@ -21,12 +21,12 @@ jobs:
     steps:
 
     - name: Checkout current repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
 
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.10'
+        python-version: '3.11'
 
     - name: Install dependancies
       run: |

.github/workflows/CI_docs_build_and_check.yml

@@ -1,4 +1,4 @@
-# Copyright (c) 2020-2021 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2020-2023 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
 
 name: CI_docs_check
 
@@ -16,16 +16,16 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: ['3.8']
+        python-version: ['3.11']
 
     steps:
       # Checkout our repository
       - name: Checkout current repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       # Set up Python
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 

.github/workflows/CI_docs_build_and_publish.yml

@@ -1,4 +1,4 @@
-# Copyright (c) 2020-2021 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2020-2023 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
 #
 # This will build the docs and push them to the gh-pages branch of the repo
 # Assumes a few things: 1) docs live in ./docs; 2) there is a doc_build.sh bash script that takes
@@ -23,16 +23,16 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: [3.9]
+        python-version: ['3.11']
 
     steps:
       # Checkout our repository
       - name: Checkout current repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       # Also check out the live docs, placing it into a pseudo "build" folder for the docs
       - name: Checkout live docs
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
             repository: MeteoSwiss/ampycloud
             ref: gh-pages
@@ -51,7 +51,7 @@ jobs:
 
       # Set up Python
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
             python-version: ${{ matrix.python-version }}
 

.github/workflows/CI_pylinter.yml

@@ -1,6 +1,6 @@
 # Inspired from: https://github.com/PyCQA/pylint/pull/2758#issuecomment-561164761
 #
-# Copyright (c) 2020-2021 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2020-2023 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
 
 name: CI_pylinter
 
@@ -18,16 +18,16 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: ['3.10']
+        python-version: ['3.11']
 
     steps:
       # Checkout our repository
       - name: Checkout current repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       # Set up Python
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 

.github/workflows/CI_pypi.yml

@@ -4,7 +4,7 @@
 #
 # It will trigger the moment a new release or pre-release is being published.
 #
-# Copyright (c) 2022 fpavogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2022-2023 fpavogt; frederic.vogt@meteoswiss.ch
 
 name: CI_pypi
 
@@ -19,12 +19,12 @@ jobs:
     steps:
 
     - name: Checkout current repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
 
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.10'
+        python-version: '3.11'
 
     - name: Install dependancies
       run: |

.github/workflows/CI_pytest.yml

@@ -3,7 +3,7 @@
 # https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
 # Adapted from: https://github.com/actions/starter-workflows/blob/master/ci/python-package.yml
 #
-# Copyright (c) 2020-2021 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
+# Copyright (c) 2020-2023 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
 
 name: CI_pytest
 
@@ -21,16 +21,16 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python-version: ['3.8', '3.9', '3.10']
+        python-version: ['3.9', '3.10', '3.11']
 
     steps:
     # Checkout the repository
     - name: Checkout current repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
 
     # Setup python
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
 

.github/workflows/CI_pytest_weekly.yml

@@ -0,0 +1,70 @@
+# This workflow will install Python dependencies and run tests with a variety of Python
+# versions, with a trigger based on specific schedule.  For more information see:
+# https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
+# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
+#
+# Adapted from: https://github.com/actions/starter-workflows/blob/master/ci/python-package.yml
+#
+# Copyright (c) 2020-2023 MeteoSwiss, created by F.P.A. Vogt; frederic.vogt@meteoswiss.ch
+
+name: CI_pytest_weekly
+
+on:
+  schedule:
+    - cron: '43 21 * * 1,4'  # Run at 21:43 UTC every Monday and Thursday
+
+jobs:
+  pytest:
+
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        #python-version: # Use the latest Python version available for this test.
+
+    steps:
+    # Checkout the master branch from the repository
+    # The idea for this Action is to spot issues with new dependency versions as soon as they
+    # are released (and not when we decide to update ampycloud).
+    - name: Checkout current repository
+      uses: actions/checkout@v3
+      with:
+        repository: MeteoSwiss/ampycloud
+        ref: master
+
+    # Setup python
+    - name: Set up Python
+      uses: actions/setup-python@v4
+      #with:
+      #  python-version: ${{ matrix.python-version }}
+
+    # Check the python/conda setup (can be useful to diagnose bug with this Action)
+    # Powershell syntax adapted from:
+    # https://stackoverflow.com/questions/63805/equivalent-of-nix-which-command-in-powershell
+    # Answer from: petrsnd
+    - name: Check the setup (I)
+      if: matrix.os == 'windows-latest'
+      run: |
+        Get-Command python | Select-Object -ExpandProperty Definition
+        echo $CONDA
+
+    - name: Check the setup (II)
+      if: matrix.os != 'windows-latest'
+      run: |
+        which python
+        which conda
+
+    # Install all the dependencies we require
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+
+    # Here, let's install our module to make sure all the dependencies specified in setup.py are
+    # also installed
+    - name: Install our module
+      run: pip install -e .[dev]
+
+    # Read to run all the tests !
+    - name: Run pytest
+      run: |
+        pytest -s