-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize & fix #422 #426
Modernize & fix #422 #426
Conversation
This pull request introduces 2 alerts and fixes 1 when merging 6b03016 into 55d3998 - view on LGTM.com new alerts:
fixed alerts:
|
You seem to be still making modifications. 😅 Please let me know when you're done. |
This pull request introduces 2 alerts and fixes 1 when merging 65f99cc into e8ec933 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 2 alerts when merging a164161 into e8ec933 - view on LGTM.com fixed alerts:
|
@harryadel sorry, noticed the LGTM errors so I went ahead and fixed them. There was actually one bug in that. |
This pull request fixes 2 alerts when merging 8ac80e7 into e8ec933 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging afdb125 into e8ec933 - view on LGTM.com fixed alerts:
|
Table of Contents generated with DocToc
What
clone
Why
As far as I and my IDE has seen
clone
is no longer used, please correct me if I'm missing something here.Then I have updated
var
tolet
andconst
and one loop forforEach
loop.Finally this PR also includes a proposed solution for #422.