Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize & fix #422 #426

Merged
merged 8 commits into from
Apr 26, 2021

Conversation

StorytellerCZ
Copy link
Member

@StorytellerCZ StorytellerCZ commented Apr 21, 2021

Table of Contents generated with DocToc

What

Why

As far as I and my IDE has seen clone is no longer used, please correct me if I'm missing something here.

Then I have updated var to let and const and one loop for forEach loop.

Finally this PR also includes a proposed solution for #422.

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2021

This pull request introduces 2 alerts and fixes 1 when merging 6b03016 into 55d3998 - view on LGTM.com

new alerts:

  • 2 for Assignment to constant

fixed alerts:

  • 1 for Unused variable, import, function or class

@harryadel
Copy link
Member

You seem to be still making modifications. 😅 Please let me know when you're done.

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2021

This pull request introduces 2 alerts and fixes 1 when merging 65f99cc into e8ec933 - view on LGTM.com

new alerts:

  • 2 for Assignment to constant

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2021

This pull request fixes 2 alerts when merging a164161 into e8ec933 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Unused variable, import, function or class

@StorytellerCZ
Copy link
Member Author

@harryadel sorry, noticed the LGTM errors so I went ahead and fixed them. There was actually one bug in that.

package/collection2/collection2.js Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2021

This pull request fixes 2 alerts when merging 8ac80e7 into e8ec933 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2021

This pull request fixes 2 alerts when merging afdb125 into e8ec933 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Unused variable, import, function or class

@StorytellerCZ StorytellerCZ merged commit 43c42b8 into Meteor-Community-Packages:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the name of collections in error messages
3 participants