Rounding in UIs #619

JFronny · 2021-05-01T13:24:34Z

Of course this is optional and disabled by default

Changes after my message in discord:

The background of windows is drawn 50% into the title bar and not rounded at the top in order to look like it is connected to the window
Custom rendering for rounded background outlines to facilitate transparency
Topbar is rounded. If you want i can prevent the upper edges from being rounded, though i kinda like this
Rounding is a generalized theme property (for HUD support)
HUD backgrounds are rounded

Closes #544

AstroOrbis · 2021-05-11T18:09:13Z

@seasnail8169 looks good :3

# Conflicts: # src/main/java/minegame159/meteorclient/gui/themes/meteor/MeteorGuiTheme.java

# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java

JFronny · 2021-06-08T11:10:25Z

Build failed because pipeline uses java 8

# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/CombatHud.java # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/PlayerModelHud.java

# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/HudRenderer.java

# Conflicts: # src/main/java/meteordevelopment/meteorclient/gui/themes/meteor/widgets/WMeteorQuad.java # src/main/java/meteordevelopment/meteorclient/systems/modules/render/hud/HudRenderer.java # src/main/java/meteordevelopment/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java

# Conflicts: # src/main/java/meteordevelopment/meteorclient/gui/GuiTheme.java

AstroOrbis · 2021-06-17T14:41:02Z

@seasnail8169

arlomcwalter · 2021-06-17T17:58:09Z

what

AstroOrbis · 2021-06-18T23:26:14Z

merge it or you're a baka

arlomcwalter · 2021-06-19T14:10:15Z

no

Cypphi · 2021-06-19T15:11:11Z

mfw (my face when) still not accepted

ghost · 2021-07-13T08:28:33Z

or its just not very good
well not bad but not perfect at least

Maybe add as an option instead of replacing if it isn’t already

JFronny · 2021-07-13T09:37:14Z

An option to select by how much everything is rounded is shown and set to 0 by default (= no rounding)

# Conflicts: # src/main/java/meteordevelopment/meteorclient/renderer/Mesh.java

Cypphi · 2021-08-21T15:46:17Z

It's possible to make the curves smooth with OpenGL stuff right

RedCarlos26 · 2021-08-24T20:42:23Z

It's possible to make the curves smooth with OpenGL stuff right

Yea I think so

Cypphi · 2021-08-26T21:35:52Z

TYad8FrPud.mp4

This prob was a known issue already but the hover effect overrides the rounded edges

JFronny · 2021-08-29T19:50:32Z

Already known, however these are things that I am too stupid to fix without large amounts of very bad code

AstroOrbis · 2021-08-30T00:00:06Z

TYad8FrPud.mp4

This prob was a known issue already but the hover effect overrides the rounded edges

Ain’t that sigma

Cypphi · 2021-08-30T12:33:37Z

TYad8FrPud.mp4
This prob was a known issue already but the hover effect overrides the rounded edges

Ain’t that sigma

meteor (with sigma font)

sbxte · 2021-10-04T02:30:05Z

5 month old pr

RedCarlos26 · 2021-10-25T17:53:45Z

It's been so long 🤯

AstroOrbis · 2021-10-25T18:06:03Z

cmon lets get this to a year x3

RedCarlos26 · 2021-10-25T20:23:16Z

Lets get it

Lerbiq · 2021-11-10T16:00:19Z

The pr makes the game crash with memory allocation error. "corrupted size vs. prev_size" and sometimes this "java: malloc.c:4259: _int_malloc: Assertion `(unsigned long) (size) >= (unsigned long) (nb)' failed."

This happens when you open the accounts screen with the round setting set to 7 and two cracked accounts in the manager after starting the game.

Opening the click gui before you open the accounts prevents the game from crashing, however it introduces a new issue when you then close the accounts screen, go to main menu and quit the game using the button in the game. The game will crash with this error: "double free or corruption (out)" and won't let meteor save.

Those issues seem to occur only when the round setting is set to 7 only.

MineGame159 · 2021-11-23T13:49:40Z

Closing this PR because the GUI is going go get rewritten in the near future and will most probably include rouded corners.

Wide-Cat · 2021-11-23T13:50:20Z

RIP 😔

RickyTheRacc · 2021-11-23T13:52:05Z

RIP? Minegame just confirmed gui rewrite that's sexyyy 😳

RedCarlos26 · 2022-07-09T22:59:19Z

8 months later 😭

MineGame159 · 2022-07-10T09:18:24Z

Uhhhh uhhh 👀

C10udburst · 2022-07-10T10:14:28Z

🤨

JFronny added 5 commits May 1, 2021 15:20

First attempt at rounding, not quite perfect

2cef7d6

Custom drawing for background outline (fix transparency)

e8600bc

Round top bar

14eba34

Make TopBarButton with edges default case

2aac4aa

Round Combat and PlayerModel HUD element backgrounds

b74f5bb

JFronny changed the title ~~Allow rounding edges in UIs~~ Rounding in UIs May 2, 2021

AstroOrbis approved these changes May 10, 2021

View reviewed changes

JFronny and others added 2 commits May 11, 2021 14:01

Round flat inventory HUD

a218d20

Merge branch 'MeteorDevelopment:master' into rounded-ui

9f5540c

AstroOrbis approved these changes May 11, 2021

View reviewed changes

JFronny and others added 4 commits May 20, 2021 17:30

Merge branch 'MeteorDevelopment:master' into rounded-ui

f5e847f

Expose logic for drawing partial circles

186a89d

Merge remote-tracking branch 'origin/master' into rounded-ui

db8a9db

# Conflicts: # src/main/java/minegame159/meteorclient/gui/themes/meteor/MeteorGuiTheme.java

Merge remote-tracking branch 'origin/master' into rounded-ui

ad58388

# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java

JFronny added 4 commits June 10, 2021 15:33

Fix

d07e057

Merge remote-tracking branch 'origin/master' into rounded-ui

543c97f

# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/HudRenderer.java

Optimize circlePartOutline

c5f98a4

AstroOrbis approved these changes Jun 11, 2021

View reviewed changes

JFronny added 3 commits June 14, 2021 20:32

Fix

cb0ca2d

Merge remote-tracking branch 'origin/master' into rounded-ui

b65c5e7

# Conflicts: # src/main/java/meteordevelopment/meteorclient/gui/GuiTheme.java

AstroOrbis approved these changes Jun 17, 2021

View reviewed changes

JFronny added 5 commits July 19, 2021 13:44

Merge remote-tracking branch 'origin/master' into rounded-ui

dfc9230

# Conflicts: # src/main/java/meteordevelopment/meteorclient/renderer/Mesh.java

Fix Mesh addition

37cc259

Merge remote-tracking branch 'origin/master' into rounded-ui

9281345

Remove seams in MeteorWidget.renderBackground

f3fdb37

Merge branch 'master' into rounded-ui

8093f10

JFronny added 2 commits August 21, 2021 18:48

Merge remote-tracking branch 'origin/master' into rounded-ui

9c1cfd3

Update mesh patch for DMA

1c42070

st6xxx approved these changes Oct 25, 2021

View reviewed changes

C10udburst approved these changes Nov 6, 2021

View reviewed changes

MineGame159 closed this Nov 23, 2021

JFronny deleted the rounded-ui branch November 23, 2021 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rounding in UIs #619

Rounding in UIs #619

JFronny commented May 1, 2021 •

edited

AstroOrbis commented May 11, 2021

JFronny commented Jun 8, 2021

AstroOrbis commented Jun 17, 2021

arlomcwalter commented Jun 17, 2021

AstroOrbis commented Jun 18, 2021

arlomcwalter commented Jun 19, 2021

Cypphi commented Jun 19, 2021

ghost commented Jul 13, 2021

JFronny commented Jul 13, 2021

Cypphi commented Aug 21, 2021

RedCarlos26 commented Aug 24, 2021

Cypphi commented Aug 26, 2021 •

edited

JFronny commented Aug 29, 2021

AstroOrbis commented Aug 30, 2021

Cypphi commented Aug 30, 2021 •

edited

sbxte commented Oct 4, 2021

RedCarlos26 commented Oct 25, 2021

AstroOrbis commented Oct 25, 2021

RedCarlos26 commented Oct 25, 2021

Lerbiq commented Nov 10, 2021

MineGame159 commented Nov 23, 2021

Wide-Cat commented Nov 23, 2021

RickyTheRacc commented Nov 23, 2021

RedCarlos26 commented Jul 9, 2022 •

edited

MineGame159 commented Jul 10, 2022

C10udburst commented Jul 10, 2022

Rounding in UIs #619

Rounding in UIs #619

Conversation

JFronny commented May 1, 2021 • edited

AstroOrbis commented May 11, 2021

JFronny commented Jun 8, 2021

AstroOrbis commented Jun 17, 2021

arlomcwalter commented Jun 17, 2021

AstroOrbis commented Jun 18, 2021

arlomcwalter commented Jun 19, 2021

Cypphi commented Jun 19, 2021

ghost commented Jul 13, 2021

JFronny commented Jul 13, 2021

Cypphi commented Aug 21, 2021

RedCarlos26 commented Aug 24, 2021

Cypphi commented Aug 26, 2021 • edited

JFronny commented Aug 29, 2021

AstroOrbis commented Aug 30, 2021

Cypphi commented Aug 30, 2021 • edited

sbxte commented Oct 4, 2021

RedCarlos26 commented Oct 25, 2021

AstroOrbis commented Oct 25, 2021

RedCarlos26 commented Oct 25, 2021

Lerbiq commented Nov 10, 2021

MineGame159 commented Nov 23, 2021

Wide-Cat commented Nov 23, 2021

RickyTheRacc commented Nov 23, 2021

RedCarlos26 commented Jul 9, 2022 • edited

MineGame159 commented Jul 10, 2022

C10udburst commented Jul 10, 2022

JFronny commented May 1, 2021 •

edited

Cypphi commented Aug 26, 2021 •

edited

Cypphi commented Aug 30, 2021 •

edited

RedCarlos26 commented Jul 9, 2022 •

edited